-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-100479: Add optional blueprint
argument to pathlib.PurePath
#100481
Closed
Closed
Changes from 17 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a6fdd0e
Add `pathlib.PurePath.makepath()`; unify path object construction
barneygale b061747
Fix reST role name.
barneygale 99eb8b1
Move call to `os.getcwd()` back into `Path.cwd()`
barneygale 4759d01
Merge branch 'main' into gh-100479-add-makepath
barneygale ef6f4c3
Merge branch 'main' into gh-100479-add-makepath
barneygale 595b8ae
Add news blurb.
barneygale dcfe70a
Merge branch 'main' into gh-100479-add-makepath
barneygale 117fe4b
Add whatsnew entry
barneygale e75dedc
Merge branch 'main' into gh-100479-add-makepath
barneygale 5a6bd3f
Merge branch 'main' into gh-100479-add-makepath
barneygale f2f1048
other --> pathsegments
barneygale 3c172fb
Update Lib/pathlib.py
barneygale 4637109
joinpath(*args) --> joinpath(*pathsegments)
barneygale ae48454
Restore _PathParents
barneygale e7a8fe3
Add note to `parents` about potential reference cycle.
barneygale 7f12faa
Replace `makepath()` method with `template` initialiser argument.
barneygale 687c764
Apply suggestions from code review
barneygale d7e326a
Fix docs for other classes.
barneygale a65d499
Pass template to `super()` to support diamond inheritance.
barneygale d4b15d7
Fixed missed `template` argument to super().
barneygale 958b183
template --> blueprint
barneygale 1e10188
Merge branch 'main' into gh-100479-add-makepath
barneygale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
Misc/NEWS.d/next/Library/2023-04-03-22-02-35.gh-issue-100479.kNBjQm.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Add optional *template* argument to :class:`pathlib.PurePath` and | ||
:class:`~pathlib.Path`. This argument is supplied whenever a derivative path | ||
is created, such as from :attr:`pathlib.PurePath.parent`. Subclasses may use | ||
to pass information to derivative paths. Patch by Barney Gale. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to specify that
template: Self | None
here? I.e. that if template is not None, it will be an instance of the current (user-defined) class.A