Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-89727: Fix os.fwalk RecursionError on deep trees #100347

Closed
wants to merge 31 commits into from

Commits on Dec 19, 2022

  1. Configuration menu
    Copy the full SHA
    d9f6f44 View commit details
    Browse the repository at this point in the history
  2. use _WalkAction enum

    jonburdo committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    61b8078 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d5e2042 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. fix formatting

    jonburdo committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    90c123b View commit details
    Browse the repository at this point in the history
  2. remove enum from os

    jonburdo committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    570818b View commit details
    Browse the repository at this point in the history
  3. add blurb

    jonburdo committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    30aeed7 View commit details
    Browse the repository at this point in the history
  4. pythongh-89727: Fix os.walk RecursionError on deep trees (python#99803)

    Use a stack to implement os.walk iteratively instead of recursively to
    avoid hitting recursion limits on deeply nested trees.
    jonburdo committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    55e17b8 View commit details
    Browse the repository at this point in the history
  5. pythongh-69929: re docs: Add more specific definition of \w (python#9…

    …2015)
    
    Co-authored-by: Jelle Zijlstra <[email protected]>
    2 people authored and jonburdo committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    f41cef6 View commit details
    Browse the repository at this point in the history
  6. pythongh-89051: Add ssl.OP_LEGACY_SERVER_CONNECT (python#93927)

    Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
    Co-authored-by: Christian Heimes <[email protected]>
    Co-authored-by: Hugo van Kemenade <[email protected]>
    Fixes python#89051
    graingert authored and jonburdo committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    33ba6a5 View commit details
    Browse the repository at this point in the history
  7. pythongh-88211: Change lower-case and upper-case to match recommendat…

    …ions in imaplib docs (python#99625)
    tbwolfe authored and jonburdo committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    f9b6796 View commit details
    Browse the repository at this point in the history
  8. pythongh-100348: Fix ref cycle in asyncio._SelectorSocketTransport

    …with `_read_ready_cb` (python#100349)
    rkojedzinszky authored and jonburdo committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    77d160f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    db820a2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c39ce63 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8d2befb View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    d29188e View commit details
    Browse the repository at this point in the history
  13. fix comments

    jonburdo committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    2cf7550 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    f2cca94 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    af18a1d View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Configuration menu
    Copy the full SHA
    9eedf9a View commit details
    Browse the repository at this point in the history
  2. add more reliable file descriptor closing logic in os.fwalk

    Make sure file descriptors get closed if an exception occurs right after the file descriptor was popped from the stack. Also catch exceptions thrown by calling os.close on an already-closed file-descriptor when doing file descriptor cleanup.
    jonburdo committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    5ee50c6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f0f9330 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ccfb955 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    598bdf9 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Configuration menu
    Copy the full SHA
    c158be3 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2023

  1. make sure we don't close the same fd twice

    If an exception occurred between `close(fd_stack[-1])` and `fd_stack.pop()`, then we would close the fd a second time in the except clause. It would be better to risk leaving the fd open, as the previous implementation of fwalk could
    jonburdo committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    6608a6a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d026146 View commit details
    Browse the repository at this point in the history
  3. remove unused variable

    jonburdo committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    762c03a View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2023

  1. Configuration menu
    Copy the full SHA
    045fd88 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f3f793a View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Configuration menu
    Copy the full SHA
    dfb9685 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Configuration menu
    Copy the full SHA
    0ebc475 View commit details
    Browse the repository at this point in the history