-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-100227: Port dup3_works to the module state variable. #100262
Conversation
✅ Deploy Preview for python-cpython-preview canceled.
|
IMHO, we should keep all cached process-level resource availability/capability checks as static global variables. I'm specifically talking about the following group (and any others we might add in the future): cpython/Tools/c-analyzer/cpython/ignored.tsv Lines 16 to 23 in b7e4f1d
Making any of them per-interpreter is unnecessary since the value will always be uniform for the process. Moving them to |
tl;dr I'd rather we keep In the case of |
Okay, I understood :) |
Thanks for working on this though! |
dup3_works
is safe to be ported as the module state variable since there is just one writing accessing in L9462.Even if there are duplicated updatings for the
dup3_works
due to the race condition,dup3_works
will not be updated anymore after the initial trial.