Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old MSVC cannot use Argument Clinic in .cpp files #96665

Closed
zooba opened this issue Sep 7, 2022 · 0 comments
Closed

Old MSVC cannot use Argument Clinic in .cpp files #96665

zooba opened this issue Sep 7, 2022 · 0 comments
Assignees

Comments

@zooba
Copy link
Member

zooba commented Sep 7, 2022

When adding _wmimodule.cpp (which requires C++ to use some COM APIs), it also used argument clinic.

However, argument clinic uses C++20 features (designated initializers). While we can enable this option with MSVC to use the C++ compiler, this breaks on older versions that are definitely used by buildbots and likely used by some developers.

To work around this, we either stop using clinic for this module, or add a fallback for older MSVC versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant