Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE - Fix help_url calculation on Windows. #95841

Closed
terryjreedy opened this issue Aug 9, 2022 · 0 comments
Closed

IDLE - Fix help_url calculation on Windows. #95841

terryjreedy opened this issue Aug 9, 2022 · 0 comments
Assignees
@terryjreedy
Labels
OS-windows topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@terryjreedy
Copy link
Member

terryjreedy commented Aug 9, 2022 •
edited
Loading

#91242 replaced the Windows .chm help file with a copy of the html docs.
Fix the Windows code in editor.EditorWindow.__init__ that gets the url.
Minimize the change to maximize the chance to apply to 3.11.0rc1.

Followup with #95844.
@terryjreedy terryjreedy added type-bug An unexpected behavior, bug, or error OS-windows topic-IDLE labels Aug 9, 2022
@terryjreedy terryjreedy self-assigned this Aug 9, 2022
@terryjreedy terryjreedy mentioned this issue Aug 9, 2022
Open
terryjreedy added a commit to terryjreedy/cpython that referenced this issue Aug 10, 2022
@terryjreedy
pythongh-95841: IDLE - Revise Windows local doc url
eb11a46 
python#91242 replaced the Windows chm help file with a copy
of the html docs.  This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.
@bedevere-bot bedevere-bot mentioned this issue Aug 10, 2022
Merged
@terryjreedy terryjreedy moved this to In Progress in IDLE Issues Aug 11, 2022
@terryjreedy terryjreedy mentioned this issue Aug 11, 2022
Open
terryjreedy added a commit that referenced this issue Aug 11, 2022
@terryjreedy
gh-95841: IDLE - Revise Windows local doc url (#95845)
bdb2cf8 
#91242 replaced the Windows chm help file with a copy
of the html docs.  This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.
Co-authored-by: Steve Dower
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 11, 2022
@terryjreedy @miss-islington
pythongh-95841: IDLE - Revise Windows local doc url (pythonGH-95845)
4093c82 
pythonGH-91242 replaced the Windows chm help file with a copy
of the html docs.  This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.
Co-authored-by: Steve Dower
(cherry picked from commit bdb2cf8)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Aug 11, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 11, 2022
@terryjreedy @miss-islington
pythongh-95841: IDLE - Revise Windows local doc url (pythonGH-95845)
d734492 
pythonGH-91242 replaced the Windows chm help file with a copy
of the html docs.  This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.
Co-authored-by: Steve Dower
(cherry picked from commit bdb2cf8)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Aug 11, 2022
Merged
miss-islington added a commit that referenced this issue Aug 11, 2022
@miss-islington @terryjreedy
gh-95841: IDLE - Revise Windows local doc url (GH-95845)
bfaa071 
GH-91242 replaced the Windows chm help file with a copy
of the html docs.  This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.
Co-authored-by: Steve Dower
(cherry picked from commit bdb2cf8)

Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy pushed a commit that referenced this issue Aug 12, 2022
@miss-islington
gh-95841: IDLE - Revise Windows local doc url (GH-95845) (#95905)
577dbc3 
GH-91242 replaced the Windows chm help file with a copy
of the html docs.  This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.

Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Steve Dower
Approved by Steve Dower, #95845 (review), 2nd subblock.

(cherry picked from commit bdb2cf8)
Repository owner moved this from In Progress to Done in IDLE Issues Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terryjreedy terryjreedy

Labels
OS-windows topic-IDLE type-bug An unexpected behavior, bug, or error
Projects
IDLE Issues
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terryjreedy