Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coverage] codeobject.c: decode_linetable #94816

Open
Tracked by #94808
mdboom opened this issue Jul 13, 2022 · 1 comment
Open
Tracked by #94808

[coverage] codeobject.c: decode_linetable #94816

mdboom opened this issue Jul 13, 2022 · 1 comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@mdboom
Copy link
Contributor

mdboom commented Jul 13, 2022

decode_linetable and its dependents emit_pair and emit_delta all seem to be uncovered by the test suite.
@mdboom mdboom added the type-bug An unexpected behavior, bug, or error label Jul 13, 2022
@mdboom mdboom mentioned this issue Jul 13, 2022
Open
@bedevere-bot bedevere-bot mentioned this issue Jul 14, 2022
Merged
mdboom added a commit to mdboom/cpython that referenced this issue Jul 14, 2022
@mdboom
pythongh-94816: Improve coverage of decode_linetable
751bacf 
This makes calls to co_lnotab to exercise this code, as well
as generating synthetically large code to exercise the corner
cases where line numbers need multiple bytes.
miss-islington pushed a commit that referenced this issue Jul 14, 2022
@mdboom
gh-94816: Improve coverage of decode_linetable (GH-94853)
20b9d2a 
This makes calls to co_lnotab to exercise this code, as well
as generating synthetically large code to exercise the corner
cases where line numbers need multiple bytes.

Automerge-Triggered-By: GH:brandtbucher
@mdboom mdboom closed this as completed Jul 15, 2022
@mdboom mdboom reopened this Jul 15, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 15, 2022
@mdboom @miss-islington
pythongh-94816: Improve coverage of decode_linetable (pythonGH-94853)
f8d5018 
This makes calls to co_lnotab to exercise this code, as well
as generating synthetically large code to exercise the corner
cases where line numbers need multiple bytes.

Automerge-Triggered-By: GH:brandtbucher
(cherry picked from commit 20b9d2a)

Co-authored-by: Michael Droettboom <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Jul 15, 2022
Closed
@mdboom mdboom closed this as completed Jul 15, 2022
@brandtbucher
Copy link
Member

Is this done? I think the backport exposed a potential issue with the new tests (see my comment on the PR).

@mdboom mdboom reopened this Jul 18, 2022
mdboom added a commit to mdboom/cpython that referenced this issue Jul 18, 2022
@mdboom
Revert "pythongh-94816: Improve coverage of decode_linetable (pythonG…
f9e135e 
…H-94853)"

This reverts commit 20b9d2a.
@bedevere-bot bedevere-bot mentioned this issue Jul 18, 2022
Merged
brandtbucher pushed a commit that referenced this issue Jul 18, 2022
@mdboom
Revert "gh-94816: Improve coverage of decode_linetable (GH-94853)" (G…
4b5360c 
…H-94982)

This reverts commit 20b9d2a.
@iritkatriel iritkatriel added tests Tests in the Lib/test dir interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdboom @iritkatriel @brandtbucher