Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceDenied raised in TransientResource but not imported in test_urllib2net #93112

Closed
The-Compiler opened this issue May 23, 2022 · 2 comments · Fixed by #93113
Closed

ResourceDenied raised in TransientResource but not imported in test_urllib2net #93112

The-Compiler opened this issue May 23, 2022 · 2 comments · Fixed by #93113
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@The-Compiler
Copy link
Contributor

Bug report

TransientResource was moved out of test.support in 311110a (GH-20812) by @vstinner, thus making ResourceDenied undefined here:

cpython/Lib/test/test_urllib2net.py

Line 60 in a458be3

raise ResourceDenied("an optional resource is not available")

I don't see how to best reproduce this, but I will open a PR with a fix.

(Found by running flake8 over Lib/ out of curiosity, see #93010 (comment))

Your environment

  • CPython versions tested on: (not tested, but affects) Python 3.11.0b1, 3.10.4
  • Operating system and architecture: Archlinux x86_64
@The-Compiler The-Compiler added the type-bug An unexpected behavior, bug, or error label May 23, 2022
@vstinner
Copy link
Member

Ah right, do you want to propose a fix?

@The-Compiler The-Compiler mentioned this issue May 23, 2022
Merged
@The-Compiler
Copy link
Contributor Author

@vstinner just did: #93113

@AA-Turner AA-Turner added the tests Tests in the Lib/test dir label May 23, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 24, 2022
@The-Compiler @miss-islington
pythonGH-93112: Fix missing ResourceDenied import in test_urllib2net (p…
d681cab 
…ythonGH-93113)

The code was moved out of test.support in
311110a (pythonGH-20812), thus making
ResourceDenied undefined.
(cherry picked from commit 37c9a35)

Co-authored-by: Florian Bruhin <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 24, 2022
@The-Compiler @miss-islington
pythonGH-93112: Fix missing ResourceDenied import in test_urllib2net (p…
7df7377 
…ythonGH-93113)

The code was moved out of test.support in
311110a (pythonGH-20812), thus making
ResourceDenied undefined.
(cherry picked from commit 37c9a35)

Co-authored-by: Florian Bruhin <[email protected]>
vstinner pushed a commit that referenced this issue May 24, 2022
@The-Compiler
GH-93112: Fix missing ResourceDenied import in test_urllib2net (#93113)
37c9a35 
The code was moved out of test.support in
311110a (GH-20812), thus making
ResourceDenied undefined.
miss-islington added a commit that referenced this issue May 24, 2022
@miss-islington @The-Compiler
GH-93112: Fix missing ResourceDenied import in test_urllib2net (GH-93113
db2b1e1 
)

The code was moved out of test.support in
311110a (GH-20812), thus making
ResourceDenied undefined.
(cherry picked from commit 37c9a35)

Co-authored-by: Florian Bruhin <[email protected]>
miss-islington added a commit that referenced this issue May 24, 2022
@miss-islington @The-Compiler
GH-93112: Fix missing ResourceDenied import in test_urllib2net (GH-93113
719edfa 
)

The code was moved out of test.support in
311110a (GH-20812), thus making
ResourceDenied undefined.
(cherry picked from commit 37c9a35)

Co-authored-by: Florian Bruhin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-93112: Fix missing ResourceDenied import in test_urllib2net
3 participants
@vstinner @The-Compiler @AA-Turner