Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing URLs to https in docs #91838

Closed
jeanas opened this issue Apr 22, 2022 · 5 comments
Closed

Consider changing URLs to https in docs #91838

jeanas opened this issue Apr 22, 2022 · 5 comments
Assignees
@serhiy-storchaka
Labels
docs Documentation in the Doc dir

Comments

@jeanas
Copy link
Contributor

jeanas commented Apr 22, 2022

Many URLs in the documentation are using the HTTP protocol:

cpython/Doc$ git grep "http://" | wc -l
460
cpython/Doc$ git grep "https://" | wc -l
805

A number of these could be converted to HTTPS. If this would be welcome, I am willing to open a PR for that, converting them with a script that checks if the HTTPS equivalent is reachable.
@jeanas jeanas added the docs Documentation in the Doc dir label Apr 22, 2022
@serhiy-storchaka
Copy link
Member

AFAIK many URLs were converted to HTTPS several years ago. These that left are URLs which do not work with HTTPS or redirect to HTTP. Things could changed since and more URLs could be now converted to HTTPS, but you should test that it is a canonical representation. Not only that the HTTPS equivalent is reachable, but that it is not a redirection to HTTP.

@slateny
Copy link
Contributor

slateny commented Jul 30, 2022

What would be the concern if links converted to https redirects to http?

@serhiy-storchaka
Copy link
Member

It does not have advantages over keeping the HTTP link, but it would mislead the user.

@jean-abou-samra, if you are willing to open a PR for that, please go ahead, but test also that the replacements are meaningful. Otherwise I'll close this issue.

@serhiy-storchaka serhiy-storchaka added the pending The issue will be closed if no feedback is provided label Jul 31, 2022
@jeanas
Copy link
Contributor Author

jeanas commented Jul 31, 2022 via email

@slateny slateny closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2022
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 1, 2022
@serhiy-storchaka
pythongh-91838: Use HTTPS links in docs for resources which redirect …
c7a2725 
…to HTTPS

If an HTTP link is redirected to a same looking HTTPS link, the latter can
be used directly without changes in readability and behavior.
It protects from a men-in-the-middle attack.

This change does not affect Python examples.
@bedevere-bot bedevere-bot mentioned this issue Aug 1, 2022
Merged
@serhiy-storchaka
Copy link
Member

I already started a work for the most harmless changes.

@serhiy-storchaka serhiy-storchaka removed the pending The issue will be closed if no feedback is provided label Aug 1, 2022
@serhiy-storchaka serhiy-storchaka self-assigned this Aug 1, 2022
serhiy-storchaka added a commit that referenced this issue Aug 4, 2022
@serhiy-storchaka
gh-91838: Use HTTPS links in docs for resources which redirect to HTT…
f79547a 
…PS (GH-95527)

If an HTTP link is redirected to a same looking HTTPS link, the latter can
be used directly without changes in readability and behavior.
It protects from a men-in-the-middle attack.

This change does not affect Python examples.
This was referenced Aug 4, 2022
Merged
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 4, 2022
@serhiy-storchaka
[3.11] pythongh-91838: Use HTTPS links in docs for resources which re…
139af36 
…direct to HTTPS (pythonGH-95527)

If an HTTP link is redirected to a same looking HTTPS link, the latter can
be used directly without changes in readability and behavior.
It protects from a men-in-the-middle attack.

This change does not affect Python examples..
(cherry picked from commit f79547a)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Aug 4, 2022
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 4, 2022
@serhiy-storchaka
pythongh-91838: Use HTTPS links in docs for resources which redirect …
c00f59f 
…to HTTPS (pythonGH-95527)

If an HTTP link is redirected to a same looking HTTPS link, the latter can
be used directly without changes in readability and behavior.
It protects from a men-in-the-middle attack.

This change does not affect Python examples.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 4, 2022
@serhiy-storchaka
[3.10] pythongh-91838: Use HTTPS links in docs for resources which re…
1a0b850 
…direct to HTTPS (pythonGH-95527)

If an HTTP link is redirected to a same looking HTTPS link, the latter can
be used directly without changes in readability and behavior.
It protects from a men-in-the-middle attack.

This change does not affect Python examples..
(cherry picked from commit f79547a)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this issue Aug 4, 2022
@serhiy-storchaka
[3.11] gh-91838: Use HTTPS links in docs for resources which redirect…
d8df7e0 
… to HTTPS (GH-95527) (GH-95643)

If an HTTP link is redirected to a same looking HTTPS link, the latter can
be used directly without changes in readability and behavior.
It protects from a men-in-the-middle attack.

This change does not affect Python examples..
(cherry picked from commit f79547a)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this issue Aug 4, 2022
@serhiy-storchaka
[3.10] gh-91838: Use HTTPS links in docs for resources which redirect…
54d4b4d 
… to HTTPS (GH-95527) (GH-95644)

If an HTTP link is redirected to a same looking HTTPS link, the latter can
be used directly without changes in readability and behavior.
It protects from a men-in-the-middle attack.

This change does not affect Python examples..
(cherry picked from commit f79547a)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 4, 2022
@serhiy-storchaka
pythongh-91838: Resolve HTTP links which redirect to HTTPS
1f2080c 
It updates links which redirect to HTTPS with different authority or
path.
This was referenced Aug 4, 2022
Merged
Merged
serhiy-storchaka added a commit that referenced this issue Aug 4, 2022
@serhiy-storchaka
gh-91838: Resolve HTTP links which redirect to HTTPS (GH-95642)
d0d0154 
It updates links which redirect to HTTPS with different authority or
path.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 4, 2022
@serhiy-storchaka @miss-islington
pythongh-91838: Resolve HTTP links which redirect to HTTPS (pythonGH-…
bc5bac0 
…95642)

It updates links which redirect to HTTPS with different authority or
path.
(cherry picked from commit d0d0154)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 4, 2022
@serhiy-storchaka @miss-islington
pythongh-91838: Resolve HTTP links which redirect to HTTPS (pythonGH-…
7c482c9 
…95642)

It updates links which redirect to HTTPS with different authority or
path.
(cherry picked from commit d0d0154)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 4, 2022
@serhiy-storchaka
pythongh-91838: Resolve more HTTP links which redirect to HTTPS
245eae9
@bedevere-bot bedevere-bot mentioned this issue Aug 4, 2022
Merged
miss-islington added a commit that referenced this issue Aug 4, 2022
@miss-islington @serhiy-storchaka
gh-91838: Resolve HTTP links which redirect to HTTPS (GH-95642)
be30a6d 
It updates links which redirect to HTTPS with different authority or
path.
(cherry picked from commit d0d0154)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington added a commit that referenced this issue Aug 4, 2022
@miss-islington @serhiy-storchaka
gh-91838: Resolve HTTP links which redirect to HTTPS (GH-95642)
c521c5c 
It updates links which redirect to HTTPS with different authority or
path.
(cherry picked from commit d0d0154)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this issue Aug 8, 2022
@serhiy-storchaka
gh-91838: Resolve more HTTP links which redirect to HTTPS (GH-95650)
cc9160a
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 8, 2022
@serhiy-storchaka @miss-islington
pythongh-91838: Resolve more HTTP links which redirect to HTTPS (pyth…
78ec518 
…onGH-95650)

(cherry picked from commit cc9160a)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Aug 8, 2022
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 8, 2022
@serhiy-storchaka
[3.10] pythongh-91838: Resolve more HTTP links which redirect to HTTPS (
03a9f61 
pythonGH-95650).

(cherry picked from commit cc9160a)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Aug 8, 2022
Merged
serhiy-storchaka added a commit that referenced this issue Aug 8, 2022
@serhiy-storchaka
[3.10] gh-91838: Resolve more HTTP links which redirect to HTTPS (GH-…
da4aae2 
…95650). (GH-95786)

(cherry picked from commit cc9160a)

Co-authored-by: Serhiy Storchaka <[email protected]>
ambv pushed a commit that referenced this issue Aug 10, 2022
@miss-islington @serhiy-storchaka
gh-91838: Resolve more HTTP links which redirect to HTTPS (GH-95650) (G…
a42215c 
…H-95780)

(cherry picked from commit cc9160a)

Co-authored-by: Serhiy Storchaka <[email protected]>
iritkatriel pushed a commit to iritkatriel/cpython that referenced this issue Aug 11, 2022
@serhiy-storchaka @iritkatriel
pythongh-91838: Resolve more HTTP links which redirect to HTTPS (pyth…
5142c57 
…onGH-95650)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhiy-storchaka serhiy-storchaka

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@serhiy-storchaka @jeanas @slateny