Dead initialization in parse_abbr function

[alexhenrie]

BPO	43360
Nosy	@alexhenrie
PRs	gh-87526: Remove dead initialization from parse_abbr function #24700

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2021-03-02.02:25:12.944>
labels = ['type-feature', 'library', '3.10']
title = 'Dead initialization in parse_abbr function'
updated_at = <Date 2021-03-02.02:26:22.031>
user = 'https://github.com/alexhenrie'

bugs.python.org fields:

activity = <Date 2021-03-02.02:26:22.031>
actor = 'alex.henrie'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2021-03-02.02:25:12.944>
creator = 'alex.henrie'
dependencies = []
files = []
hgrepos = []
issue_num = 43360
keywords = ['patch']
message_count = 1.0
messages = ['387895']
nosy_count = 1.0
nosy_names = ['alex.henrie']
pr_nums = ['24700']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue43360'
versions = ['Python 3.10']

[alexhenrie]

The parse_abbr function in _zoneinfo.c currently initializes the variable buff regardless of whether it is going to be used, and then initializes it again in the one path that does use it. The first initialization could be removed to simplify the code and clarify its intent.

Defect identified by scan-build <https://clang-analyzer.llvm.org/scan-build.html\>