-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Backport test_cext and test_cppext (C API tests) from main to the 3.12 branch #127906
Comments
On the 3.12 branch, test_cext currently fails with these warnings:
I backported MSVC support in Py_UNUSED() to 3.12 to fix unicodeobject.h: PR gh-127907. |
I wrote #127908 to fix this pytime.h warning. |
(cherry picked from commit d05a4e6) Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit d05a4e6) Co-authored-by: Victor Stinner <[email protected]>
A 3.13 buildbots is failing on |
Also, on 3.12, |
Oh, right: I created PR gh-127993 to fix this buildbot. |
Change Py_BUILD_ASSERT_EXPR implementation on Windows to avoid a compiler warning about an unnamed structure.
Oh, I see. I forgot to backport yet another fix for Py_BUILD_ASSERT_EXPR() on Windows. I created PR gh-127994 to fix this buildbot as well. Thanks @encukou for reporting these issues! Sadly, test_cext and test_cppext are skipped on GitHub CI jobs since they are too slow. |
The 3.12 TraceRefs and 3.13 buildbots are back to green. I close the issue. |
Thank you! |
The C API is not well tested in the 3.12 branch. I propose to backport test_cext and test_cppext from the main branch to the 3.12 branch.
Example of recent C++ regression: #127902
Linked PRs
The text was updated successfully, but these errors were encountered: