Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong opname in 3.13 dis module documentation #125875

Closed
stopa27 opened this issue Oct 23, 2024 · 3 comments
Closed

wrong opname in 3.13 dis module documentation #125875

stopa27 opened this issue Oct 23, 2024 · 3 comments
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes docs Documentation in the Doc dir

Comments

@stopa27
Copy link

stopa27 commented Oct 23, 2024 •
edited by bedevere-app bot
Loading

According to python 3.13 changelog there are three new opcodes replacing FORMAT_VALUE - CONVERT_VALUE, FORMAT_SIMPLE and FORMAT_WITH_SPEC.
But in https://docs.python.org/3/library/dis.html there are mentioned CONVERT_VALUE, FORMAT_SIMPLE and FORMAT_SPEC

Linked PRs
@stopa27 stopa27 added the docs Documentation in the Doc dir label Oct 23, 2024
@tomasr8
Copy link
Member

tomasr8 commented Oct 23, 2024

Looks like a typo in the docs, would you like to open a PR?

@tomasr8 tomasr8 added 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Oct 23, 2024
@corona10
Copy link
Member

corona10 commented Nov 2, 2024

@willingc and @Mariatta
@rimi0108 She is the first-time contributor who is participating in the CPython Sprint KR today.
She is going to take a look at this issue :)

@bedevere-app bedevere-app bot mentioned this issue Nov 2, 2024
Merged
corona10 pushed a commit that referenced this issue Nov 2, 2024
@rimi0108
gh-125875: Fix docs typo FORMAT_SPEC to FORMAT_WITH_SPEC (gh-126319)
914356f 
Fix docs typo FORMAT_SPEC to FORMAT_WITH_SPEC
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 2, 2024
@rimi0108 @miss-islington
pythongh-125875: Fix docs typo FORMAT_SPEC to FORMAT_WITH_SPEC (pytho…
5b43981 
…ngh-126319)

Fix docs typo FORMAT_SPEC to FORMAT_WITH_SPEC
(cherry picked from commit 914356f4d485e378eb692e57d822b893acc0c0da)

Co-authored-by: rimchoi <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Nov 2, 2024
Merged
corona10 pushed a commit that referenced this issue Nov 2, 2024
@miss-islington
[3.13] gh-125875: Fix docs typo FORMAT_SPEC to FORMAT_WITH_SPEC (gh-1…
6e4b7ea 
…26319) (gh-126320)
@corona10
Copy link
Member

corona10 commented Nov 2, 2024

Thank you @rimi0108 for contributing, let's close the issue :)

@corona10 corona10 closed this as completed Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@corona10 @tomasr8 @stopa27