Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsan: fix race:sock_recv_impl suppressions for free-thread building #123695

Closed
Zheaoli opened this issue Sep 4, 2024 · 1 comment
Closed

tsan: fix race:sock_recv_impl suppressions for free-thread building #123695

Zheaoli opened this issue Sep 4, 2024 · 1 comment
Labels
type-feature A feature request or enhancement

Comments

@Zheaoli
Copy link
Contributor

Zheaoli commented Sep 4, 2024

Feature or enhancement

Proposal:

The root cause of this race here is we use the same socket in the server and client side in our test. I think this is wrong

FYI https://github.com/python/cpython/blob/main/Lib/test/test_socket.py#L4817-L4825

I think we just need make a small patch for test case

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs

@Zheaoli Zheaoli added the type-feature A feature request or enhancement label Sep 4, 2024
Zheaoli added a commit to Zheaoli/cpython that referenced this issue Sep 4, 2024
@mpage
Copy link
Contributor

mpage commented Sep 4, 2024

Thanks for doing this! We're tracking work to remove TSAN suppressions for free-threading builds in #117657. Can you please close this issue and associate #123697 with #117657?

@Zheaoli Zheaoli closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants