Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tkinter.ttk with Tcl/Tk 9.0 #120211

Closed
Tracked by #104568
serhiy-storchaka opened this issue Jun 7, 2024 · 0 comments
Closed
Tracked by #104568

Fix tkinter.ttk with Tcl/Tk 9.0 #120211

serhiy-storchaka opened this issue Jun 7, 2024 · 0 comments
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes topic-tkinter

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jun 7, 2024 •
edited by bedevere-app bot
Loading

There are two issues in tkinter.ttk with Tcl/Tk 9.0.

  • Using the Variable methods trace_variable() and trace_vdelete(). They wrap deprecated Tcl commands which were removed in Tcl 9.0. New methods added in Add new methods to trace Tkinter variables #66313 should be used instead (added in Python 3.6 and supported in Tcl 8.4 or older).
  • Combobox.current() fails because the underlying Tk command returns now an empty string instead of -1 for empty combobox. It would be right to translate it to None, but -1 is more backward compatible. In future we can change this method to return None.

Linked PRs
@serhiy-storchaka serhiy-storchaka added topic-tkinter 3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Jun 7, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jun 7, 2024
@serhiy-storchaka
pythongh-120211: Fix tkinter.ttk with Tcl/Tk 9.0
b03627f 
* Use new methods for tracing Tcl variable.
* Fix Combobox.current() for empty combobox.
@bedevere-app bedevere-app bot mentioned this issue Jun 7, 2024
Merged
serhiy-storchaka added a commit that referenced this issue Jun 7, 2024
@serhiy-storchaka
gh-120211: Fix tkinter.ttk with Tcl/Tk 9.0 (GH-120213)
d68a22e 
* Use new methods for tracing Tcl variable.
* Fix Combobox.current() for empty combobox.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 7, 2024
@serhiy-storchaka @miss-islington
pythongh-120211: Fix tkinter.ttk with Tcl/Tk 9.0 (pythonGH-120213)
bb39914 
* Use new methods for tracing Tcl variable.
* Fix Combobox.current() for empty combobox.
(cherry picked from commit d68a22e)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 7, 2024
@serhiy-storchaka @miss-islington
pythongh-120211: Fix tkinter.ttk with Tcl/Tk 9.0 (pythonGH-120213)
be19854 
* Use new methods for tracing Tcl variable.
* Fix Combobox.current() for empty combobox.
(cherry picked from commit d68a22e)

Co-authored-by: Serhiy Storchaka <[email protected]>
This was referenced Jun 7, 2024
Merged
Merged
serhiy-storchaka added a commit that referenced this issue Jun 7, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-120211: Fix tkinter.ttk with Tcl/Tk 9.0 (GH-120213) (GH-120216
ac68d83 
)

* Use new methods for tracing Tcl variable.
* Fix Combobox.current() for empty combobox.
(cherry picked from commit d68a22e)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka mentioned this issue Jun 7, 2024
Open
16 tasks
serhiy-storchaka added a commit that referenced this issue Jun 7, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-120211: Fix tkinter.ttk with Tcl/Tk 9.0 (GH-120213) (GH-120215
8368b67 
)

* Use new methods for tracing Tcl variable.
* Fix Combobox.current() for empty combobox.
(cherry picked from commit d68a22e)

Co-authored-by: Serhiy Storchaka <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@serhiy-storchaka @noahbkim
pythongh-120211: Fix tkinter.ttk with Tcl/Tk 9.0 (pythonGH-120213)
a614b59 
* Use new methods for tracing Tcl variable.
* Fix Combobox.current() for empty combobox.
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@serhiy-storchaka @estyxx
pythongh-120211: Fix tkinter.ttk with Tcl/Tk 9.0 (pythonGH-120213)
49a3b51 
* Use new methods for tracing Tcl variable.
* Fix Combobox.current() for empty combobox.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes topic-tkinter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka