Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_dataclass fails with -OO mode #115285

Closed
sobolevn opened this issue Feb 11, 2024 · 1 comment
Closed

test_dataclass fails with -OO mode #115285

sobolevn opened this issue Feb 11, 2024 · 1 comment
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Feb 11, 2024 •
edited by bedevere-app bot
Loading

Bug report

Output:

» ./python.exe -OO Lib/test/test_dataclasses/__init__.py
.................................................................................................................................F..........................................................................................................
======================================================================
FAIL: test_existing_docstring_not_overridden (__main__.TestDocString.test_existing_docstring_not_overridden)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/sobolev/Desktop/cpython2/Lib/test/test_dataclasses/__init__.py", line 2225, in test_existing_docstring_not_overridden
    self.assertEqual(C.__doc__, "Lorem ipsum")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'C(x: int)' != 'Lorem ipsum'
- C(x: int)
+ Lorem ipsum

I have a PR ready.

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Feb 11, 2024
@sobolevn sobolevn self-assigned this Feb 11, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Feb 11, 2024
@sobolevn
pythongh-115285: Fix test_dataclasses with -OO mode
3bdf6b8
@bedevere-app bedevere-app bot mentioned this issue Feb 11, 2024
Merged
@sobolevn
Copy link
Member Author

sobolevn commented Feb 11, 2024 •
edited
Loading

This is the last -OO problem I could find 🎉

sobolevn added a commit that referenced this issue Feb 12, 2024
@sobolevn
gh-115285: Fix test_dataclasses with -OO mode (#115286)
4297d73
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 12, 2024
@sobolevn @miss-islington
pythongh-115285: Fix test_dataclasses with -OO mode (pythonGH-115286
2026d81 
)

(cherry picked from commit 4297d73)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 12, 2024
@sobolevn @miss-islington
pythongh-115285: Fix test_dataclasses with -OO mode (pythonGH-115286
1597d7b 
)

(cherry picked from commit 4297d73)

Co-authored-by: Nikita Sobolev <[email protected]>
This was referenced Feb 12, 2024
Merged
Merged
sobolevn added a commit that referenced this issue Feb 12, 2024
@miss-islington @sobolevn
[3.11] gh-115285: Fix test_dataclasses with -OO mode (GH-115286) (#…
d732134 
…115358)

gh-115285: Fix `test_dataclasses` with `-OO` mode (GH-115286)
(cherry picked from commit 4297d73)

Co-authored-by: Nikita Sobolev <[email protected]>
sobolevn added a commit that referenced this issue Feb 12, 2024
@miss-islington @sobolevn
[3.12] gh-115285: Fix test_dataclasses with -OO mode (GH-115286) (#…
2ed47d8 
…115359)

gh-115285: Fix `test_dataclasses` with `-OO` mode (GH-115286)
(cherry picked from commit 4297d73)

Co-authored-by: Nikita Sobolev <[email protected]>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this issue Feb 14, 2024
@sobolevn @fsc-eriker
pythongh-115285: Fix test_dataclasses with -OO mode (python#115286)
b79bd64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolevn