Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_property fails with -00 mode #115254

Closed
sobolevn opened this issue Feb 10, 2024 · 2 comments
Closed

test_property fails with -00 mode #115254

sobolevn opened this issue Feb 10, 2024 · 2 comments
Assignees
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Feb 10, 2024

Bug report

» ./python.exe -OO -m test test_property  
Using random seed: 1955187317
0:00:00 load avg: 2.91 Run 1 test sequentially
0:00:00 load avg: 2.91 [1/1] test_property
test test_property failed -- Traceback (most recent call last):
  File "/Users/sobolev/Desktop/cpython2/Lib/test/test_property.py", line 233, in test_slots_docstring_copy_exception
    with self.assertRaises(AttributeError):
    ...<4 lines>...
                return 1
AssertionError: AttributeError not raised

test_property failed (1 failure)

== Tests result: FAILURE ==

1 test failed:
    test_property

Total duration: 27 ms
Total tests: run=27 failures=1 skipped=12
Total test files: run=1/1 failed=1
Result: FAILURE

I have a PR ready.

Linked PRs

@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Feb 10, 2024
@sobolevn sobolevn self-assigned this Feb 10, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Feb 10, 2024
@terryjreedy
Copy link
Member

Great idea to run test suite this way.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 10, 2024
(cherry picked from commit b70a68f)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 10, 2024
(cherry picked from commit b70a68f)

Co-authored-by: Nikita Sobolev <[email protected]>
sobolevn added a commit that referenced this issue Feb 11, 2024
…15262)

(cherry picked from commit b70a68f)

Co-authored-by: Nikita Sobolev <[email protected]>
sobolevn added a commit that referenced this issue Feb 11, 2024
…15261)

gh-115254: Fix `test_property` with `-00` mode (GH-115255)
(cherry picked from commit b70a68f)

Co-authored-by: Nikita Sobolev <[email protected]>
@sobolevn
Copy link
Member Author

Done!

fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this issue Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants