Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify branches and deopts in the tier 2 IR. #111848

Closed
markshannon opened this issue Nov 8, 2023 · 2 comments
Closed

Unify branches and deopts in the tier 2 IR. #111848

markshannon opened this issue Nov 8, 2023 · 2 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@markshannon
Copy link
Member

markshannon commented Nov 8, 2023 •
edited by bedevere-app bot
Loading

The basic premise of optimizing traces is that most branches are highly biased.
So we use DEOPT_IF to branch in the uncommon case.
However in the optimizer we may want to move work to exit branches, which needs jumps.
Unifying branches and jumps also simplifies the tier 2 interpreter and the JIT compiler.

So, let's merge jumps and branches, as follows:

  • Convert most, if not all jumps in the tier 2 code to DEOPT_IFs in bytecodes.c
  • Convert deopts into jumps internally to allow work like SET_IP to be sunk into exit branches.

See also #111610

Linked PRs
@markshannon markshannon added the performance Performance or resource usage label Nov 8, 2023
@bedevere-app bedevere-app bot mentioned this issue Nov 8, 2023
Merged
markshannon added a commit that referenced this issue Nov 8, 2023
@markshannon
GH-111848: Tidy up tier 2 handling of FOR_ITER specialization by usin…
06efb60 
…g DEOPT_IF instead of jumps. (GH-111849)
@brandtbucher
Copy link
Member

Yes please! :)

@bedevere-app bedevere-app bot mentioned this issue Nov 13, 2023
Merged
@Eclips4 Eclips4 added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Nov 13, 2023
markshannon added a commit that referenced this issue Nov 14, 2023
@markshannon
GH-111848: Convert remaining jumps to deopts into tier 2 code. (GH-11…
a519b87 
…2045)
@bedevere-app bedevere-app bot mentioned this issue Nov 15, 2023
Merged
markshannon added a commit that referenced this issue Nov 15, 2023
@markshannon
GH-111848: Set the IP when de-optimizing (GH-112065)
4bbb367 
* Replace jumps with deopts in tier 2

* Fewer special cases of uop names

* Add target field to uop IR

* Remove more redundant SET_IP and _CHECK_VALIDITY micro-ops

* Extend whitelist of non-escaping API functions.
@bedevere-app bedevere-app bot mentioned this issue Nov 20, 2023
Merged
gvanrossum added a commit that referenced this issue Nov 20, 2023
@gvanrossum
gh-111848: Clean up RESERVE() macro (#112274)
c4c6321 
Also avoid compiler warnings about unused 'reserved' variable.
@gvanrossum
Copy link
Member

Do you expect more to happen here? It looks complete. :-)

@gvanrossum gvanrossum mentioned this issue Nov 22, 2023
Closed
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@markshannon @aisk
pythonGH-111848: Tidy up tier 2 handling of FOR_ITER specialization b…
7530441 
…y using DEOPT_IF instead of jumps. (pythonGH-111849)
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@markshannon @aisk
pythonGH-111848: Convert remaining jumps to deopts into tier 2 code. (p…
2d7da6c 
…ythonGH-112045)
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@markshannon @aisk
pythonGH-111848: Set the IP when de-optimizing (pythonGH-112065)
44f3d21 
* Replace jumps with deopts in tier 2

* Fewer special cases of uop names

* Add target field to uop IR

* Remove more redundant SET_IP and _CHECK_VALIDITY micro-ops

* Extend whitelist of non-escaping API functions.
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@gvanrossum @aisk
pythongh-111848: Clean up RESERVE() macro (python#112274)
470f58a 
Also avoid compiler warnings about unused 'reserved' variable.
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@markshannon @Glyphack
pythonGH-111848: Tidy up tier 2 handling of FOR_ITER specialization b…
5610158 
…y using DEOPT_IF instead of jumps. (pythonGH-111849)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@markshannon @Glyphack
pythonGH-111848: Convert remaining jumps to deopts into tier 2 code. (p…
25b82d8 
…ythonGH-112045)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@markshannon @Glyphack
pythonGH-111848: Set the IP when de-optimizing (pythonGH-112065)
02026ac 
* Replace jumps with deopts in tier 2

* Fewer special cases of uop names

* Add target field to uop IR

* Remove more redundant SET_IP and _CHECK_VALIDITY micro-ops

* Extend whitelist of non-escaping API functions.
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@gvanrossum @Glyphack
pythongh-111848: Clean up RESERVE() macro (python#112274)
2384007 
Also avoid compiler warnings about unused 'reserved' variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gvanrossum @markshannon @brandtbucher @Eclips4