Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --disable-gil option to configure #108223

Closed
Tracked by #108219
colesbury opened this issue Aug 21, 2023 · 3 comments
Closed
Tracked by #108219

Add --disable-gil option to configure #108223

colesbury opened this issue Aug 21, 2023 · 3 comments
Labels
3.13 bugs and security fixes build The build process and cross-build type-feature A feature request or enhancement

Comments

@colesbury
Copy link
Contributor

colesbury commented Aug 21, 2023 •
edited by bedevere-app bot
Loading

Feature or enhancement

@itamaro is working on setting up additional buildbots for PEP 703 builds. To support this, we'll add an optional --disable-gil flag to the configure. For now, this flag won't do anything other than define the Py_NOGIL macro, but once the buildbots are setup, any future code behind this flag will be tested in the CI.

Linked PRs
@colesbury colesbury added type-feature A feature request or enhancement build The build process and cross-build labels Aug 21, 2023
@colesbury colesbury mentioned this issue Aug 21, 2023
Open
colesbury added a commit to colesbury/cpython that referenced this issue Aug 21, 2023
@colesbury
pythongh-108223: Add --disable-gil to configure
057f1eb 
The `--disable-gil` flags does not do anything yet other than define the
Py_NOGIL macro. This is intended to support setting up additional
buildbots.
@itamaro itamaro added the 3.13 bugs and security fixes label Aug 21, 2023
@bedevere-bot bedevere-bot mentioned this issue Aug 21, 2023
Merged
corona10 pushed a commit that referenced this issue Aug 21, 2023
@colesbury
gh-108223: Add --disable-gil to configure (gh-108227)
b16ecb8 
The `--disable-gil` flags does not do anything yet other than define the
Py_NOGIL macro. This is intended to support setting up additional
buildbots.
@vstinner
Copy link
Member

@colesbury: Would you mind to document the new option in https://docs.python.org/dev/using/configure.html documentation? You will need a .. versionadded:: 3.13.

colesbury added a commit to colesbury/cpython that referenced this issue Aug 21, 2023
@colesbury
pythongh-108223: Document --disable-gil flag in configure
1c43a5a
@bedevere-bot bedevere-bot mentioned this issue Aug 21, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Aug 21, 2023
@vstinner
pythongh-108223: test.pythoninfo and libregrtest log Py_NOGIL
da9ef5e 
Enable with --disable-gil --without-pydebug:

    $ make pythoninfo|grep NOGIL
    sysconfig[Py_NOGIL]: 1

    $ ./python -m test
    ...
    == Python build: nogil debug
    ...
@bedevere-bot bedevere-bot mentioned this issue Aug 21, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Aug 21, 2023
@vstinner
pythongh-108223: Add [NOGIL] marker to sys.version
f4e41b8 
If Python was configured with --disable-gil, add " [NOGIL]" suffix to
sys.version. It should help users to check if they are running a
regular Python build with a GIL, or a custom Python build with the
new experimental no GIL.
vstinner added a commit to vstinner/cpython that referenced this issue Aug 21, 2023
@vstinner
pythongh-108223: Add [NOGIL] marker to sys.version
b1aa038 
If Python is configured with --disable-gil, add " [NOGIL]" suffix to
sys.version. It should help users to check if they are running a
regular Python build with a GIL, or a custom Python build with the
new experimental no GIL.

sys.version is commonly requested in bug reports: knowing if Python
was configured with --disable-gil should ease debug.

Example on Linux with --disable-gil:

    $ ./python -VV
    Python 3.13.0a0 (heads/main-dirty:d63972e289, Aug 21 2023,
    21:43:45) [GCC 13.2.1 20230728 (Red Hat 13.2.1-1)] [NOGIL]
@bedevere-bot bedevere-bot mentioned this issue Aug 21, 2023
Closed
vstinner added a commit that referenced this issue Aug 21, 2023
@vstinner
gh-108223: test.pythoninfo and libregrtest log Py_NOGIL (#108238)
5afe0c1 
Enable with --disable-gil --without-pydebug:

    $ make pythoninfo|grep NOGIL
    sysconfig[Py_NOGIL]: 1

    $ ./python -m test
    ...
    == Python build: nogil debug
    ...
vstinner pushed a commit that referenced this issue Aug 21, 2023
@colesbury
gh-108223: Document --disable-gil flag in configure (#108236)
4b32d4f
@terryjreedy
Copy link
Member

Will no-gil initially be *nix only or will no-gil builds for Windows be possible?

@itamaro
Copy link
Contributor

itamaro commented Aug 22, 2023

Will no-gil initially be *nix only or will no-gil builds for Windows be possible?

ideally we should have it for all platforms as early as possible

@colesbury colesbury mentioned this issue Aug 23, 2023
Closed
vstinner added a commit to vstinner/cpython that referenced this issue Sep 2, 2023
@vstinner
pythongh-108223: test.pythoninfo and libregrtest log Py_NOGIL (python…
15425da 
…#108238)

Enable with --disable-gil --without-pydebug:

    $ make pythoninfo|grep NOGIL
    sysconfig[Py_NOGIL]: 1

    $ ./python -m test
    ...
    == Python build: nogil debug
    ...

(cherry picked from commit 5afe0c1)
@vstinner vstinner mentioned this issue Sep 2, 2023
Merged
vstinner added a commit that referenced this issue Sep 3, 2023
@vstinner @tiran
@zware @sobolevn @zitterbewegung @gpshead
[3.11] gh-108822: Backport libregrtest changes from the main branch (#…
79f7a4c 
…108820)

* Revert "[3.11] gh-101634: regrtest reports decoding error as failed test (#106169) (#106175)"

This reverts commit d5418e9.

* Revert "[3.11] bpo-46523: fix tests rerun when `setUp[Class|Module]` fails (GH-30895) (GH-103342)"

This reverts commit ecb09a8.

* Revert "gh-95027: Fix regrtest stdout encoding on Windows (GH-98492)"

This reverts commit b2aa28e.

* Revert "[3.11] gh-94026: Buffer regrtest worker stdout in temporary file (GH-94253) (GH-94408)"

This reverts commit 0122ab2.

* Revert "Run Tools/scripts/reindent.py (GH-94225)"

This reverts commit f0f3a42.

* Revert "gh-94052: Don't re-run failed tests with --python option (GH-94054)"

This reverts commit 1347607.

* Revert "[3.11] gh-84461: Fix Emscripten umask and permission issues (GH-94002) (GH-94006)"

This reverts commit 1073184.

* gh-93353: regrtest checks for leaked temporary files (#93776)

When running tests with -jN, create a temporary directory per process
and mark a test as "environment changed" if a test leaks a temporary
file or directory.

(cherry picked from commit e566ce5)

* gh-93353: Fix regrtest for -jN with N >= 2 (GH-93813)

(cherry picked from commit 36934a1)

* gh-93353: regrtest supports checking tmp files with -j2 (#93909)

regrtest now also implements checking for leaked temporary files and
directories when using -jN for N >= 2. Use tempfile.mkdtemp() to
create the temporary directory. Skip this check on WASI.

(cherry picked from commit 4f85cec)

* gh-84461: Fix Emscripten umask and permission issues (GH-94002)

- Emscripten's default umask is too strict, see
  emscripten-core/emscripten#17269
- getuid/getgid and geteuid/getegid are stubs that always return 0
  (root). Disable effective uid/gid syscalls and fix tests that use
  chmod() current user.
- Cannot drop X bit from directory.

(cherry picked from commit 2702e40)

* gh-94052: Don't re-run failed tests with --python option (#94054)

(cherry picked from commit 0ff7b99)

* Run Tools/scripts/reindent.py (#94225)

Reindent files which were not properly formatted (PEP 8: 4 spaces).

Remove also some trailing spaces.

(cherry picked from commit e87ada4)

* gh-94026: Buffer regrtest worker stdout in temporary file (GH-94253)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit 199ba23)

* gh-96465: Clear fractions hash lru_cache under refleak testing (GH-96689)

Automerge-Triggered-By: GH:zware
(cherry picked from commit 9c8f379)

* gh-95027: Fix regrtest stdout encoding on Windows (#98492)

On Windows, when the Python test suite is run with the -jN option,
the ANSI code page is now used as the encoding for the stdout
temporary file, rather than using UTF-8 which can lead to decoding
errors.

(cherry picked from commit ec1f6f5)

* gh-98903: Test suite fails with exit code 4 if no tests ran (#98904)

The Python test suite now fails wit exit code 4 if no tests ran. It
should help detecting typos in test names and test methods.

* Add "EXITCODE_" constants to Lib/test/libregrtest/main.py.
* Fix a typo: "NO TEST RUN" becomes "NO TESTS RAN"

(cherry picked from commit c76db37)

* gh-100086: Add build info to test.libregrtest (#100093)

The Python test runner (libregrtest) now logs Python build information like
"debug" vs "release" build, or LTO and PGO optimizations.

(cherry picked from commit 3c89202)

* bpo-46523: fix tests rerun when `setUp[Class|Module]` fails (#30895)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 9953860)

* gh-82054: allow test runner to split test_asyncio to execute in parallel by sharding. (#103927)

This runs test_asyncio sub-tests in parallel using sharding from Cinder. This suite is typically the longest-pole in runs because it is a test package with a lot of further sub-tests otherwise run serially. By breaking out the sub-tests as independent modules we can run a lot more in parallel.

After porting we can see the direct impact on a multicore system.

Without this change:
  Running make test is 5 min 26 seconds
With this change:
  Running make test takes 3 min 39 seconds

That'll vary based on system and parallelism. On a `-j 4` run similar to what CI and buildbot systems often do, it reduced the overall test suite completion latency by 10%.

The drawbacks are that this implementation is hacky and due to the sorting of the tests it obscures when the asyncio tests occur and involves changing CPython test infrastructure but, the wall time saved it is worth it, especially in low-core count CI runs as it pulls a long tail. The win for productivity and reserved CI resource usage is significant.

Future tests that deserve to be refactored into split up suites to benefit from are test_concurrent_futures and the way the _test_multiprocessing suite gets run for all start methods. As exposed by passing the -o flag to python -m test to get a list of the 10 longest running tests.

---------

Co-authored-by: Carl Meyer <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]> [Google, LLC]
(cherry picked from commit 9e011e7)

* Display the sanitizer config in the regrtest header. (#105301)

Display the sanitizers present in libregrtest.

Having this in the CI output for tests with the relevant environment
variable displayed will help make it easier to do what we need to
create an equivalent local test run.

(cherry picked from commit 852348a)

* gh-101634: regrtest reports decoding error as failed test (#106169)

When running the Python test suite with -jN option, if a worker stdout
cannot be decoded from the locale encoding report a failed testn so the
exitcode is non-zero.

(cherry picked from commit 2ac3eec)

* gh-108223: test.pythoninfo and libregrtest log Py_NOGIL (#108238)

Enable with --disable-gil --without-pydebug:

    $ make pythoninfo|grep NOGIL
    sysconfig[Py_NOGIL]: 1

    $ ./python -m test
    ...
    == Python build: nogil debug
    ...

(cherry picked from commit 5afe0c1)

* gh-90791: test.pythoninfo logs ASAN_OPTIONS env var (#108289)

* Cleanup libregrtest code logging ASAN_OPTIONS.
* Fix a typo on "ASAN_OPTIONS" vs "MSAN_OPTIONS".

(cherry picked from commit 3a1ac87)

* gh-108388: regrtest splits test_asyncio package (#108393)

Currently, test_asyncio package is only splitted into sub-tests when
using command "./python -m test". With this change, it's also
splitted when passing it on the command line:
"./python -m test test_asyncio".

Remove the concept of "STDTESTS". Python is now mature enough to not
have to bother with that anymore. Removing STDTESTS simplify the
code.

(cherry picked from commit 174e9da)

* regrtest computes statistics (#108793)

test_netrc, test_pep646_syntax and test_xml_etree now return results
in the test_main() function.

Changes:

* Rewrite TestResult as a dataclass with a new State class.
* Add test.support.TestStats class and Regrtest.stats_dict attribute.
* libregrtest.runtest functions now modify a TestResult instance
  in-place.
* libregrtest summary lists the number of run tests and skipped
  tests, and denied resources.
* Add TestResult.has_meaningful_duration() method.
* Compute TestResult duration in the upper function.
* Use time.perf_counter() instead of time.monotonic().
* Regrtest: rename 'resource_denieds' attribute to 'resource_denied'.
* Rename CHILD_ERROR to MULTIPROCESSING_ERROR.
* Use match/case syntadx to have different code depending on the
  test state.

Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit d4e534c)

* gh-108822: Add Changelog entry for regrtest statistics (#108821)

---------

Co-authored-by: Christian Heimes <[email protected]>
Co-authored-by: Zachary Ware <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: Joshua Herman <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
corona10 added a commit to corona10/cpython that referenced this issue Oct 19, 2023
@corona10
pythongh-108223: Add nogil build test on Github Action
1d0c718
@bedevere-app bedevere-app bot mentioned this issue Oct 19, 2023
Closed
vstinner added a commit to vstinner/cpython that referenced this issue Dec 5, 2023
@vstinner
pythongh-108223: Refer to PEP 703 as Free Threading
3fb74b8
vstinner added a commit to vstinner/cpython that referenced this issue Dec 5, 2023
@vstinner
pythongh-108223: Refer to PEP 703 as Free Threading
6606ae2 
Rename support.Py_GIL_DISABLED to support.FREE_THREADING.
@bedevere-app bedevere-app bot mentioned this issue Dec 5, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Dec 6, 2023
@vstinner
pythongh-108223: Refer to PEP 703 as Free Threading
87709aa
vstinner added a commit that referenced this issue Dec 6, 2023
@vstinner
gh-108223: Refer to PEP 703 as Free Threading (#112780)
f885263
@dzejkob-b dzejkob-b mentioned this issue Feb 9, 2024
Open
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@vstinner @aisk
pythongh-108223: Refer to PEP 703 as Free Threading (python#112780)
1a8ae85
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@vstinner @Glyphack
pythongh-108223: Refer to PEP 703 as Free Threading (python#112780)
66501b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes build The build process and cross-build type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vstinner @itamaro @colesbury @terryjreedy