Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cases_generator tests aren't run by CI, and are broken #105540

Closed
3 of 4 tasks
gvanrossum opened this issue Jun 9, 2023 · 2 comments
Closed
3 of 4 tasks

cases_generator tests aren't run by CI, and are broken #105540

gvanrossum opened this issue Jun 9, 2023 · 2 comments
Labels
easy type-bug An unexpected behavior, bug, or error

Comments

@gvanrossum
Copy link
Member

gvanrossum commented Jun 9, 2023 •
edited by bedevere-bot
Loading

There are some tests for the cases generator in Tools/cases_generator/test_generator.py, but several things are wrong with these:

  • They are currently broken
  • They depend on pytest
  • They aren't run in CI
  • They are incomplete

Let's fix that (in that order).

Linked PRs
@gvanrossum gvanrossum added the type-bug An unexpected behavior, bug, or error label Jun 9, 2023
@gvanrossum gvanrossum mentioned this issue Jun 9, 2023
Merged
@bedevere-bot bedevere-bot mentioned this issue Jun 12, 2023
Merged
gvanrossum added a commit that referenced this issue Jun 12, 2023
@gvanrossum
gh-105540: Fix code generator tests (#105707)
8da9d1b 
This involves expanding PEEK, POKE and JUMPBY macros,
and removing super and register tests (those features no longer exist).
carljm added a commit to carljm/cpython that referenced this issue Jun 12, 2023
@carljm
Merge branch 'main' into modulelocals
2fae889 
* main:
  pythongh-105540: Fix code generator tests (python#105707)
  pythongh-105375: Explicitly initialise all {Pickler,Unpickler}Object fields (python#105686)
  pythongh-105331: Change `asyncio.sleep` to raise ``ValueError` for nan (python#105641)
  Remove support for legacy bytecode instructions (python#105705)
@gvanrossum
Copy link
Member Author

This should be pretty easy -- just Python code. Especially the next step (removing the pytest dependency in favor of unittest) should be quite doable.

sobolevn added a commit to sobolevn/cpython that referenced this issue Jul 13, 2023
@sobolevn
pythongh-105540: Convert pytest tests of cases_generator to regul…
96ebd50 
…ar tests
@bedevere-bot bedevere-bot mentioned this issue Jul 13, 2023
Merged
@kgdiem kgdiem mentioned this issue Jul 13, 2023
Closed
gvanrossum pushed a commit that referenced this issue Jul 16, 2023
@sobolevn
gh-105540: Convert pytest tests of cases_generator to regular tes…
c413207 
…ts (#106713)
@bedevere-bot bedevere-bot mentioned this issue Jul 20, 2023
Merged
gvanrossum added a commit that referenced this issue Jul 20, 2023
@gvanrossum
gh-105540: Show source files relative to root (#106927)
1218910 
This restores a corner case: when the generator is run with working directory set to Tools/cases_generator, the source filenames listed in the generated provenance header should be relative to the repo root directory.
sobolevn added a commit to sobolevn/cpython that referenced this issue Jul 21, 2023
@sobolevn
pythongh-105540: Improve relative paths in generate_cases.py
7445cf8
@bedevere-bot bedevere-bot mentioned this issue Jul 21, 2023
Closed
@gvanrossum
Copy link
Member Author

Honestly I think we can close this issue, making the tests comprehensive will just be an ongoing task, it's not a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gvanrossum