Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad error message when inheriting from Generic multiple times #104328

Closed
JelleZijlstra opened this issue May 9, 2023 · 0 comments
Closed

Bad error message when inheriting from Generic multiple times #104328

JelleZijlstra opened this issue May 9, 2023 · 0 comments
Labels
topic-typing type-bug An unexpected behavior, bug, or error

Comments

@JelleZijlstra
Copy link
Member

JelleZijlstra commented May 9, 2023 •
edited by bedevere-bot
Loading 

>>> from typing import Generic, TypeVar
>>> T = TypeVar("T")
>>> U = TypeVar("U")
>>> class X(Generic[T], Generic[U]): pass
... 
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/jelle/py/cpython/Lib/typing.py", line 1088, in _generic_init_subclass
    raise TypeError(
TypeError: Cannot inherit from Generic[...] multiple types.

Should say "multiple times".

Noticed by @carljm in #103764 (comment).

Linked PRs
@JelleZijlstra JelleZijlstra added type-bug An unexpected behavior, bug, or error topic-typing labels May 9, 2023
@JelleZijlstra JelleZijlstra mentioned this issue May 9, 2023
Merged
@bedevere-bot bedevere-bot mentioned this issue May 9, 2023
Merged
carljm pushed a commit that referenced this issue May 9, 2023
@Eclips4
gh-104328: Fix typo in typing.Generic multiple inheritance error …
01c321c 
…message (#104335)
@bedevere-bot bedevere-bot mentioned this issue May 9, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 9, 2023
@Eclips4 @miss-islington
pythongh-104328: Fix typo in typing.Generic multiple inheritance …
528cc01 
…error message (pythonGH-104335)

(cherry picked from commit 01c321c)

Co-authored-by: Kirill Podoprigora <[email protected]>
AlexWaygood pushed a commit that referenced this issue May 9, 2023
@miss-islington @Eclips4
[3.11] gh-104328: Fix typo in typing.Generic multiple inheritance…
663b321 
… error message (GH-104335) (#104338)

gh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (GH-104335)
(cherry picked from commit 01c321c)

Co-authored-by: Kirill Podoprigora <[email protected]>
@carljm carljm closed this as completed May 9, 2023
carljm added a commit to carljm/cpython that referenced this issue May 10, 2023
@carljm
Merge branch 'main' into fixloadsuperspec
5976df9 
* main:
  pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182)
  pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364)
  pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539)
  pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292)
  pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202)
  pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013)
  pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355)
  pythongh-103960: Dark mode: invert image brightness (python#103983)
  pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253)
  pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354)
  pythongh-101819: Harden _io init (python#104352)
  pythongh-103247: clear the module cache in a test in test_importlib/extensions/test_loader.py (pythonGH-104226)
  pythongh-103848: Adds checks to ensure that bracketed hosts found by urlsplit are of IPv6 or IPvFuture format (python#103849)
  pythongh-74895: adjust tests to work on Solaris (python#104326)
  pythongh-101819: Refactor _io in preparation for module isolation (python#104334)
  pythongh-90953: Don't use deprecated AST nodes in clinic.py (python#104322)
  pythongh-102327: Extend docs for "url" and "headers" parameters to HTTPConnection.request()
  pythongh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (python#104335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-typing type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carljm @JelleZijlstra