gh-100348: Fix ref cycle in asyncio._SelectorSocketTransport with `…

…_read_ready_cb` (#100349)
python · Dec 20, 2022 · a6331b6 · a6331b6
1 parent 39dfbb2
commit a6331b6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/Lib/asyncio/selector_events.py b/Lib/asyncio/selector_events.py
@@ -1133,6 +1133,10 @@ def _make_empty_waiter(self):
     def _reset_empty_waiter(self):
         self._empty_waiter = None
 
+    def close(self):
+        self._read_ready_cb = None
+        super().close()
+
 
 class _SelectorDatagramTransport(_SelectorTransport, transports.DatagramTransport):
 

diff --git a/Misc/NEWS.d/next/Library/2022-12-19-19-30-06.gh-issue-100348.o7IAHh.rst b/Misc/NEWS.d/next/Library/2022-12-19-19-30-06.gh-issue-100348.o7IAHh.rst
@@ -0,0 +1,2 @@
+Fix ref cycle in :class:`!asyncio._SelectorSocketTransport` by removing ``_read_ready_cb`` in ``close``.
+