Skip to content

Commit

Permalink
[3.9] bpo-47004: Sync with importlib_metadata 4.11.3. (GH-31854).
Browse files Browse the repository at this point in the history
(cherry picked from commit b1e2868)

Co-authored-by: Jason R. Coombs <[email protected]>
  • Loading branch information
jaraco committed Mar 13, 2022
1 parent bda64b3 commit 8e3f39f
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 2 deletions.
2 changes: 2 additions & 0 deletions Doc/library/importlib.metadata.rst
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ function::
["pytest (>=3.0.0) ; extra == 'test'", "pytest-cov ; extra == 'test'"]


.. _distributions:

Distributions
=============

Expand Down
13 changes: 11 additions & 2 deletions Lib/importlib/metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ class EntryPoint(
See `the packaging docs on entry points
<https://packaging.python.org/specifications/entry-points/>`_
for more information.
>>> ep = EntryPoint(
... name=None, group=None, value='package.module:attr [extra1, extra2]')
>>> ep.module
'package.module'
>>> ep.attr
'attr'
>>> ep.extras
['extra1', 'extra2']
"""

pattern = re.compile(
Expand Down Expand Up @@ -91,7 +100,7 @@ def attr(self):
@property
def extras(self):
match = self.pattern.match(self.value)
return list(re.finditer(r'\w+', match.group('extras') or ''))
return re.findall(r'\w+', match.group('extras') or '')

@classmethod
def _from_config(cls, config):
Expand Down Expand Up @@ -308,7 +317,7 @@ def _read_dist_info_reqs(self):

def _read_egg_info_reqs(self):
source = self.read_text('requires.txt')
return source and self._deps_from_requires_text(source)
return None if source is None else self._deps_from_requires_text(source)

@classmethod
def _deps_from_requires_text(cls, source):
Expand Down
10 changes: 10 additions & 0 deletions Lib/test/test_importlib/test_metadata_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,16 @@ def test_requires_egg_info(self):
for dep in deps
)

def test_requires_egg_info_empty(self):
fixtures.build_files(
{
'requires.txt': '',
},
self.site_dir.joinpath('egginfo_pkg.egg-info'),
)
deps = requires('egginfo-pkg')
assert deps == []

def test_requires_dist_info(self):
deps = requires('distinfo-pkg')
assert len(deps) == 2
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Apply bugfixes from importlib_metadata 4.11.3, including bugfix for
EntryPoint.extras, which was returning match objects and not the extras
strings.

0 comments on commit 8e3f39f

Please sign in to comment.