Skip to content

Commit

Permalink
gh-113343: Fix error check on mmap(2) (#113342)
Browse files Browse the repository at this point in the history
Fix error check on mmap(2)

It should check MAP_FAILED instead of NULL for error.

On mmap(2) man page:

  RETURN VALUE
       On success, mmap() returns a pointer to the mapped area.
       On error, the value MAP_FAILED (that is, (void *) -1) is
       returned, and errno is set to indicate the error.
  • Loading branch information
namhyung authored Dec 21, 2023
1 parent 5f7a80f commit 6b70c3d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Python/perf_trampoline.c
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ new_code_arena(void)
mem_size, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS,
-1, // fd (not used here)
0); // offset (not used here)
if (!memory) {
if (memory == MAP_FAILED) {
PyErr_SetFromErrno(PyExc_OSError);
PyErr_FormatUnraisable("Failed to create new mmap for perf trampoline");
perf_status = PERF_STATUS_FAILED;
Expand Down

0 comments on commit 6b70c3d

Please sign in to comment.