gh-116381: Remove bad specializations, add fail stats (GH-116464)

* Remove bad specializations, add fail stats
python · Mar 7, 2024 · 41457c7 · 41457c7
1 parent 4298d69
commit 41457c7
Show file tree

Hide file tree

Showing 16 changed files with 125 additions and 320 deletions.
diff --git a/Include/internal/pycore_list.h b/Include/internal/pycore_list.h
@@ -56,8 +56,6 @@ typedef struct {
 
 PyAPI_FUNC(PyObject *)_PyList_FromArraySteal(PyObject *const *src, Py_ssize_t n);
 
-PyAPI_FUNC(int) _PyList_Contains(PyObject *aa, PyObject *el);
-
 #ifdef __cplusplus
 }
 #endif

diff --git a/Include/internal/pycore_opcode_metadata.h b/Include/internal/pycore_opcode_metadata.h
diff --git a/Include/internal/pycore_tuple.h b/Include/internal/pycore_tuple.h
@@ -29,8 +29,6 @@ typedef struct {
     PyTupleObject *it_seq; /* Set to NULL when iterator is exhausted */
 } _PyTupleIterObject;
 
-PyAPI_FUNC(int) _PyTuple_Contains(PyTupleObject *a, PyObject *el);
-
 #ifdef __cplusplus
 }
 #endif

diff --git a/Include/internal/pycore_uop_ids.h b/Include/internal/pycore_uop_ids.h
diff --git a/Include/internal/pycore_uop_metadata.h b/Include/internal/pycore_uop_metadata.h
diff --git a/Include/opcode_ids.h b/Include/opcode_ids.h
diff --git a/Lib/_opcode_metadata.py b/Lib/_opcode_metadata.py
diff --git a/Objects/listobject.c b/Objects/listobject.c
@@ -524,8 +524,8 @@ list_length(PyObject *a)
     return PyList_GET_SIZE(a);
 }
 
-int
-_PyList_Contains(PyObject *aa, PyObject *el)
+static int
+list_contains(PyObject *aa, PyObject *el)
 {
 
     for (Py_ssize_t i = 0; ; i++) {
@@ -3147,7 +3147,7 @@ static PySequenceMethods list_as_sequence = {
     0,                                          /* sq_slice */
     list_ass_item,                              /* sq_ass_item */
     0,                                          /* sq_ass_slice */
-    _PyList_Contains,                           /* sq_contains */
+    list_contains,                              /* sq_contains */
     list_inplace_concat,                        /* sq_inplace_concat */
     list_inplace_repeat,                        /* sq_inplace_repeat */
 };

diff --git a/Objects/tupleobject.c b/Objects/tupleobject.c
@@ -349,8 +349,8 @@ tuplelength(PyTupleObject *a)
     return Py_SIZE(a);
 }
 
-int
-_PyTuple_Contains(PyTupleObject *a, PyObject *el)
+static int
+tuplecontains(PyTupleObject *a, PyObject *el)
 {
     Py_ssize_t i;
     int cmp;
@@ -758,7 +758,7 @@ static PySequenceMethods tuple_as_sequence = {
     0,                                          /* sq_slice */
     0,                                          /* sq_ass_item */
     0,                                          /* sq_ass_slice */
-    (objobjproc)_PyTuple_Contains,              /* sq_contains */
+    (objobjproc)tuplecontains,                  /* sq_contains */
 };
 
 static PyObject*
-Original file line number
+Diff line change
@@ Expand Up / @@ -56,8 +56,6 @@ typedef struct { @@
     PyAPI_FUNC(PyObject *)_PyList_FromArraySteal(PyObject *const *src, Py_ssize_t n);
-    PyAPI_FUNC(int) _PyList_Contains(PyObject *aa, PyObject *el);
     #ifdef __cplusplus
     }
     #endif
@@ Expand Down @@