Skip to content

Commit

Permalink
gh-104645: fix error handling in marshal tests
Browse files Browse the repository at this point in the history
  • Loading branch information
iritkatriel committed May 19, 2023
1 parent 616fcad commit 19b2600
Showing 1 changed file with 14 additions and 18 deletions.
32 changes: 14 additions & 18 deletions Modules/_testcapimodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -1808,10 +1808,9 @@ pymarshal_write_long_to_file(PyObject* self, PyObject *args)
}

PyMarshal_WriteLongToFile(value, fp, version);
assert(!PyErr_Occurred());

fclose(fp);
if (PyErr_Occurred())
return NULL;
Py_RETURN_NONE;
}

Expand All @@ -1834,10 +1833,9 @@ pymarshal_write_object_to_file(PyObject* self, PyObject *args)
}

PyMarshal_WriteObjectToFile(obj, fp, version);
assert(!PyErr_Occurred());

fclose(fp);
if (PyErr_Occurred())
return NULL;
Py_RETURN_NONE;
}

Expand Down Expand Up @@ -1895,48 +1893,46 @@ pymarshal_read_long_from_file(PyObject* self, PyObject *args)
static PyObject*
pymarshal_read_last_object_from_file(PyObject* self, PyObject *args)
{
PyObject *obj;
long pos;
PyObject *filename;
FILE *fp;

if (!PyArg_ParseTuple(args, "O:pymarshal_read_last_object_from_file", &filename))
return NULL;

fp = _Py_fopen_obj(filename, "rb");
FILE *fp = _Py_fopen_obj(filename, "rb");
if (fp == NULL) {
PyErr_SetFromErrno(PyExc_OSError);
return NULL;
}

obj = PyMarshal_ReadLastObjectFromFile(fp);
pos = ftell(fp);
PyObject *obj = PyMarshal_ReadLastObjectFromFile(fp);
long pos = ftell(fp);

fclose(fp);
if (obj == NULL) {
return NULL;
}
return Py_BuildValue("Nl", obj, pos);
}

static PyObject*
pymarshal_read_object_from_file(PyObject* self, PyObject *args)
{
PyObject *obj;
long pos;
PyObject *filename;
FILE *fp;

if (!PyArg_ParseTuple(args, "O:pymarshal_read_object_from_file", &filename))
return NULL;

fp = _Py_fopen_obj(filename, "rb");
FILE *fp = _Py_fopen_obj(filename, "rb");
if (fp == NULL) {
PyErr_SetFromErrno(PyExc_OSError);
return NULL;
}

obj = PyMarshal_ReadObjectFromFile(fp);
pos = ftell(fp);
PyObject *obj = PyMarshal_ReadObjectFromFile(fp);
long pos = ftell(fp);

fclose(fp);
if (obj == NULL) {
return NULL;
}
return Py_BuildValue("Nl", obj, pos);
}

Expand Down

0 comments on commit 19b2600

Please sign in to comment.