Skip to content

Commit

Permalink
gh-89363: Skip threading test_is_alive_after_fork() if ASAN (#109835)
Browse files Browse the repository at this point in the history
Skip test_is_alive_after_fork() of test_threading if Python is built
with Address Sanitizer (ASAN).
  • Loading branch information
vstinner authored and pull[bot] committed Oct 16, 2023
1 parent 651fe5b commit 1407529
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Lib/test/_test_multiprocessing.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@


if support.check_sanitizer(address=True):
# bpo-45200: Skip multiprocessing tests if Python is built with ASAN to
# gh-89363: Skip multiprocessing tests if Python is built with ASAN to
# work around a libasan race condition: dead lock in pthread_create().
raise unittest.SkipTest("libasan has a pthread_create() dead lock")

Expand Down
4 changes: 4 additions & 0 deletions Lib/test/test_threading.py
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,10 @@ def background_thread(evt):
self.assertEqual(err, b'')

@support.requires_fork()
# gh-89363: Skip multiprocessing tests if Python is built with ASAN to
# work around a libasan race condition: dead lock in pthread_create().
@support.skip_if_sanitizer("libasan has a pthread_create() dead lock",
address=True)
def test_is_alive_after_fork(self):
# Try hard to trigger #18418: is_alive() could sometimes be True on
# threads that vanished after a fork.
Expand Down

0 comments on commit 1407529

Please sign in to comment.