test: allow WEBSOCKETS_TESTS_TIMEOUT_FACTOR to be float #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
Jun 14, 2023
- Allow the timeout factor to be float: python-websockets/websockets#1371 - The patch needs to be stored in our repo because the patch of the PR won't apply to v10.4. - Set timeout factor to 1.1 to make the tests pass on riscv64 boards. (As suggested in python-websockets/websockets#1026)
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Jun 14, 2023
- Allow the timeout factor to be float: python-websockets/websockets#1371 - The patch needs to be stored in our repo because the patch of the PR won't apply to v10.4. - Set timeout factor to 1.1 to make the tests pass on riscv64 boards. (As suggested in python-websockets/websockets#1026)
|
I'm not sure how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is desirable to be able to set
WEBSOCKETS_TESTS_TIMEOUT_FACTORto a floating point value like1.1.