New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backwards compatibility issues with the removal of the `path` argument #1095

Closed

aaugustin opened this issue Nov 25, 2021 · 0 comments

Labels

Member

aaugustin commented Nov 25, 2021 •

edited

Loading

It doesn't work when the connection handler is a functools.partial.

See #1045 (comment)

Just as a side note for future compatible changes: The inspection based remove_path_argument does not work flawlessly, and fail for handlers that were created through functools.partial. (To be fair, I'm not sure such a change can be done in Python in an API preserving way; given the tools this probably even works most of the time, just not all the times).

aaugustin mentioned this issue

How to pass additional args to server function in Basic example file? #271

Closed

aaugustin added the high priority label

aaugustin closed this as completed in

d2808dc

aaugustin added a commit that referenced this issue


          Restore backwards-compatibility for partial handlers.

f605e86

Fix #1095.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment