Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Belatedly fix a bunch of small issues in the v0.9.0 release note #734

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Oct 13, 2018

No description provided.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not check why Travis is unhappy, but the wording changes look good! Do we use fan-in/fan-out anywhere else? (Can't easily check from my phone.)

@njsmith
Copy link
Member Author

njsmith commented Oct 14, 2018

Travis failure is just a job that failed to launch, just needs restarting. I can do it when I'm at a computer with credentials.

We did originally use fan-in/fan-out terminology, but then I did more research and find that that's mostly used for when you send duplicates of the same info to different places, so i switched it everywhere. Except i missed the release note. Not a big deal, but since I was fixing the other garbled stuff anyway I figured I'd get it too.

@codecov
Copy link

codecov bot commented Oct 14, 2018

Codecov Report

Merging #734 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          96       96           
  Lines       11464    11464           
  Branches      820      820           
=======================================
  Hits        11386    11386           
  Misses         58       58           
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cffb536...2315ffb. Read the comment docs.

@pquentin pquentin merged commit bdb5320 into python-trio:master Oct 14, 2018
@pquentin
Copy link
Member

Thanks, merged!

Yeah, I was aware of the fan-in/fan-out -> producers/consumers change. I tried to be useful by reviewing quickly, but I was not: if I was going to leave a review, I should have checked those two things myself. Sorry about that. I'll try to improve on this front.

(Note that if you're signed into GitHub from your phone, you can easily sign into Travis. But being able to do more things from your phone is not necessarily a good idea!)

@njsmith njsmith deleted the better-release-note-for-0.9.0 branch October 14, 2018 05:22
@njsmith
Copy link
Member Author

njsmith commented Oct 14, 2018

Yeah, I was aware of the fan-in/fan-out -> producers/consumers change. I tried to be useful by reviewing quickly, but I was not: if I was going to leave a review, I should have checked those two things myself. Sorry about that. I'll try to improve on this front.

Hey, seriously, don't worry about it :-). There is literally nothing wrong with a review that's a bit quick and sloppy – it often catches stuff, it helps us realize which things are unclear to a hurried reader and pushes us to clarify them, it's way better than no review at all. If we had infinite energy and attention we could just get the changes right in the first place and wouldn't need review! The whole point of review is that we're messy and fallible and a few pairs of messy fallible eyes are better than one.

@pquentin
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants