Support binding to a source address. #518
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's also an open issue at #275, which has a bit more discussion of the subtleties here. This works in simple cases, but it forces a choice of IPv4/IPv6 (whichever one you use as the source), and there's some problem around picking a port given that we might be making multiple connections... let's move the discussion there. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #518 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 113 113
Lines 16919 16919
Branches 3050 3050
=======================================
Hits 16741 16741
Misses 123 123
Partials 55 55
|
miracle2k
force-pushed
the
source-binds
branch
from
24e5b1e to
aafdcfb
Compare
miracle2k
force-pushed
the
source-binds
branch
from
aafdcfb to
5babfe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to set the source ip address for a request. I see that there is a TODO in the code. This seems to work for me, which seems almost too easy. Is there something else?