-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sphinx #3070
Update sphinx #3070
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3070 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 121 121
Lines 17850 17855 +5
Branches 3208 3208
=======================================
+ Hits 17784 17789 +5
Misses 46 46
Partials 20 20
|
Ok most of those is that Sphinx doesn't seem to like referencing a superclass. That makes no sense! Somehow the changes are from sphinx-doc/sphinx@1ff9adf. Because it's trying to refer to the classes it derives from and then tries getting them from |
OK filed python/cpython#123250, but there's things we can do to work around this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. python/cpython#123250 is quite interesting, I hope there will be a fix eventually. I was wondering while looking at this, any particular reason to use 3.11 over 3.12 now that we are upgrading?
No, just when we changed the version I think it wasn't supported by RTD. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sad to need ugly workarounds, but seems worth it
I was looking at #2921 and wondering why Sphinx wasn't getting updated. Turns out they dropped support for Python 3.8. However, our RTD build runs in Python 3.11 so we can use that for the docs requirements.