Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we're running on M1 MacOS #2953

Closed
wants to merge 2 commits into from

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Feb 12, 2024

macos-latest doesn't seem to include macos-14: https://github.com/python-trio/trio/actions/runs/7865413592/job/21458313729#step:1:8

So this should make things run on M1 macs.

Reference: #2885

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (b4c19bc) to head (811d289).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2953       +/-   ##
===========================================
- Coverage   99.63%   80.89%   -18.74%     
===========================================
  Files         117      117               
  Lines       17602    17557       -45     
  Branches     3174     1398     -1776     
===========================================
- Hits        17537    14202     -3335     
- Misses         46     3250     +3204     
- Partials       19      105       +86     

see 64 files with indirect coverage changes

@A5rocks A5rocks mentioned this pull request Feb 12, 2024
17 tasks
@A5rocks
Copy link
Contributor Author

A5rocks commented Feb 12, 2024

Oh despite 3.8 and 3.9 having installers that work on arm, it looks like setup-python doesn't recognize that yet: actions/setup-python#808

From the issue it sounds like all that's missing is someone needs to build for 3.8 and 3.9 arm64? So I'm comfortable letting this sit until that happens.

@A5rocks A5rocks marked this pull request as draft February 12, 2024 04:17
@A5rocks A5rocks marked this pull request as ready for review April 26, 2024 04:43
@A5rocks
Copy link
Contributor Author

A5rocks commented Apr 26, 2024

This should be unblocked now

@A5rocks
Copy link
Contributor Author

A5rocks commented Apr 26, 2024

Actually this is no longer necessary

macos-latest will now be M1 macos

@A5rocks A5rocks closed this Apr 26, 2024
@A5rocks A5rocks deleted the m1-macos-runs branch April 26, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant