Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the minimum attrs ver for @frozen #2499

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

FasterSpeeding
Copy link
Contributor

@FasterSpeeding FasterSpeeding commented Dec 12, 2022

I've run MyPy and pytest against this locally with the new minimum attrs version installed to make sure this bump fixes the problem.

Would've waited until #2449 was merged to open this but that seems a bit stalled.

Fixes: #2439

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #2499 (6fb73ea) into master (f39d3a4) will increase coverage by 0.86%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2499      +/-   ##
==========================================
+ Coverage   97.98%   98.84%   +0.86%     
==========================================
  Files         118      118              
  Lines       16324    16324              
  Branches     3156     3156              
==========================================
+ Hits        15995    16136     +141     
+ Misses        266      133     -133     
+ Partials       63       55       -8     
Impacted Files Coverage Δ
trio/_core/_run.py 99.45% <0.00%> (+0.43%) ⬆️
trio/tests/test_socket.py 99.83% <0.00%> (+0.64%) ⬆️
trio/_core/tests/test_io.py 100.00% <0.00%> (+1.05%) ⬆️
trio/tests/test_highlevel_open_tcp_stream.py 100.00% <0.00%> (+1.47%) ⬆️
trio/_subprocess_platform/__init__.py 100.00% <0.00%> (+5.71%) ⬆️
trio/_core/__init__.py 100.00% <0.00%> (+12.50%) ⬆️
trio/lowlevel.py 100.00% <0.00%> (+16.66%) ⬆️
trio/_core/_io_kqueue.py 84.67% <0.00%> (+83.87%) ⬆️
trio/_subprocess_platform/kqueue.py 100.00% <0.00%> (+100.00%) ⬆️

Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just leaving a note here that while attr.frozen was added in 20.1.0, that was only provisionally (it was stablized seemingly in 21.1.0). That shouldn't affect anything, of course. I don't think there were any API changes, just bugfixes.

@harahu harahu merged commit 81142e1 into python-trio:master Dec 13, 2022
@trio-bot
Copy link

trio-bot bot commented Dec 13, 2022

Hey @FasterSpeeding, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

@harahu
Copy link
Contributor

harahu commented Dec 13, 2022

@FasterSpeeding thank you for the contribution 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import trio produces AttributeError with attrs version 19.2.0
3 participants