-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the minimum attrs ver for @frozen #2499
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2499 +/- ##
==========================================
+ Coverage 97.98% 98.84% +0.86%
==========================================
Files 118 118
Lines 16324 16324
Branches 3156 3156
==========================================
+ Hits 15995 16136 +141
+ Misses 266 133 -133
+ Partials 63 55 -8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just leaving a note here that while attr.frozen
was added in 20.1.0, that was only provisionally (it was stablized seemingly in 21.1.0). That shouldn't affect anything, of course. I don't think there were any API changes, just bugfixes.
Hey @FasterSpeeding, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂 If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:
If you want to read more, here's the relevant section in our contributing guide. Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you. If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out! |
@FasterSpeeding thank you for the contribution 🥳 |
I've run MyPy and pytest against this locally with the new minimum attrs version installed to make sure this bump fixes the problem.
Would've waited until #2449 was merged to open this but that seems a bit stalled.
Fixes: #2439