-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI matrix. #2206
Update CI matrix. #2206
Conversation
3.6 is EOL so there's no reason to test on it. 3.8-dev and 3.9-dev are released versions, and are unnecessary. I see no reason to test on both 3.7 and 3.8 PyPy nightly.
Codecov Report
@@ Coverage Diff @@
## master #2206 +/- ##
==========================================
- Coverage 99.51% 99.47% -0.04%
==========================================
Files 114 114
Lines 14759 14759
Branches 2344 2344
==========================================
- Hits 14687 14682 -5
- Misses 47 49 +2
- Partials 25 28 +3
|
Thank you for cleaning this up! Note we now have some uncovered lines for features that were only being exercised on 3.6. I think it would make the most sense to keep at least some tests for 3.6 until we actually remove 3.6 support, but I'm also OK with committing this as-is if you plan to then remove 3.6 support and remove the 3.6-supporting code that is no longer covered. |
I've also updated the branch protection rules so that this is now mergeable. |
Sorry for the delay, new years. Yes, this is what I plan to do ASAP. |
Python 3.6 support was dropped in #2210. Testing on dev versions allows catching issues before releases, but I agree that for already released versions it's less likely to be useful. |
This would drop for 3.7 nightly and 3.8 nightly, not regular 3.7 or 3.8 with the same justification as dropping -dev for older releases. |
Right. In the past Nathaniel often raised PyPy bugs and the PyPy developers were (and still are) extremely reactive: fixes often show up in the nightly the next day. That happens less these days, though. |
pretty sure this got changed like 10000 days ago so this is no longer relevant |
3.6 is EOL so there's no reason to test on it.
3.8-dev and 3.9-dev are released versions, and are unnecessary.
I see no reason to test on both 3.7 and 3.8 PyPy nightly.