Improve stability of tests_subprocess #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2205 +/- ##
==========================================
- Coverage 99.51% 99.51% -0.01%
==========================================
Files 114 114
Lines 14778 14761 -17
Branches 2344 2346 +2
==========================================
- Hits 14706 14689 -17
Misses 47 47
Partials 25 25
|
On macOS, there appears to be some sort of race where sending SIGTERM to a process "too early" in its lifetime causes the exit status to appear as if SIGKILL was sent. I can reproduce this with the stdlib subprocess. Additionally, this problem doesn't occur if there is a tiny sleep between spawning a child subprocess and terminating it. My proposal is to use `/bin/sleep` on posix (which reliably does not have this issue on macOS) and continue using the Python form elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, there appears to be some sort of race where sending SIGTERM
to a process "too early" in its lifetime causes the exit status to
appear as if SIGKILL was sent.
I can reproduce this with the stdlib subprocess. Additionally, this
problem doesn't occur if there is a tiny sleep between spawning a
child subprocess and terminating it.
My proposal is to use
/bin/sleepon posix (which reliably does nothave this issue on macOS) and continue using the Python form elsewhere.
Related to #851. Originally submitted as #2190 (I was a bit too hasty in cleaning up my old branches)