Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't shuffle each batch, instead reverse them half the time. #1580

Merged
merged 3 commits into from
Jun 8, 2020

Conversation

palkeo
Copy link

@palkeo palkeo commented Jun 8, 2020

I consistently see batch shuffling taking 1% CPU on a real-world
application, and this is a simple fix to make this overhead disappear.
Suggested by @njsmith.

I consistently see batch shuffling taking 1% CPU on a real-world
application, and this is a simple fix to make this overhead disappear.
Suggested by @njsmith.
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #1580 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1580   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files         111      111           
  Lines       13866    13869    +3     
  Branches     1059     1060    +1     
=======================================
+ Hits        13824    13827    +3     
  Misses         27       27           
  Partials       15       15           
Impacted Files Coverage Δ
trio/_core/_run.py 99.76% <100.00%> (+<0.01%) ⬆️
trio/tests/test_scheduler_determinism.py 100.00% <100.00%> (ø)
trio/tests/test_deprecate.py 100.00% <0.00%> (ø)

The scheduler is still non-deterministic, but exhibit much less variety
of behavior, making the test a lot more likely to fail. So we increase
the size of the traces.
trio/_core/_run.py Outdated Show resolved Hide resolved
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

I don't think we need a newsfragment here, since this isn't user-visible?

@pquentin pquentin merged commit c32b1bb into python-trio:master Jun 8, 2020
@trio-bot
Copy link

trio-bot bot commented Jun 8, 2020

Hey @palkeo, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants