Drop Python 3.5 #1390
Drop Python 3.5 #1390
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1390 +/- ##
==========================================
+ Coverage 92.79% 93.54% +0.74%
==========================================
Files 106 106
Lines 13288 13180 -108
Branches 1004 991 -13
==========================================
- Hits 12331 12329 -2
+ Misses 905 800 -105
+ Partials 52 51 -1
|
|
Coverage is pointing more places where I need to change things. Unfortunately I can't put my PR in draft mode now. I'll request reviews when this is ready. |
Since we no longer support Python 3.5.
Since we no longer support Python 3.5.
Since we no longer support Python 3.5.
|
Closing for now as I'm not sure I'll be able to continue this, but keeping the branch alive in case someone wants to continue the work started here. |
|
@pquentin do you have a list of things that need to be done for completion? |
|
@wgwz Thanks for stepping up! There's nothing specific left, we just need to figure out why the tests don't pass (probably due to one of the last commits), and then make sure the coverage does not drop (which is a bit tricky since it's flaky and Windows coverage is currently broken). |
|
I realized I forgot to close, doing this now so that the work can continue in another pull request. |
|
It wouldn't be a terrible idea to stick in a deprecation warning for a
release, anyway – just check if we're on 3.5 at import, and issue a warning
if so. Do you have time for a smaller PR like that?
…On Wed, Feb 5, 2020, 10:23 Quentin Pradet ***@***.***> wrote:
Closed #1390 <#1390>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1390?email_source=notifications&email_token=AAEU42CZ4H7DSOJOM2TW4D3RBL72HA5CNFSM4KQGLS2KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWN42ZJA#event-3011095716>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEU42DKZVKWVL24OTQ3KCTRBL72HANCNFSM4KQGLS2A>
.
|
|
Yes, that would be a good first step. |
Closes #75
I'll need to write newsfragments for 1/ the actual removal 2/ the call_soon FIFO ordering guarantee.
@oremanj Can
test_abc_genericsgo away with Python 3.5 or is it still useful?