-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ipython from 7.9.0 to 7.10.0 #1320
Conversation
One of your CI runs failed on this pull request, so Dependabot won't merge it.
Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
f2f7482
to
c29ef2d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1320 +/- ##
==========================================
- Coverage 99.69% 99.38% -0.31%
==========================================
Files 106 106
Lines 13008 13008
Branches 996 996
==========================================
- Hits 12968 12928 -40
- Misses 23 54 +31
- Partials 17 26 +9
|
Bumps [ipython](https://github.com/ipython/ipython) from 7.9.0 to 7.10.0. - [Release notes](https://github.com/ipython/ipython/releases) - [Commits](ipython/ipython@7.9.0...7.10.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
c29ef2d
to
5289a64
Compare
https://github.com/ipython/ipython/blob/7.10.0/setup.py#L45-L48 |
Ick, so I guess this is another situation where we're hitting the limitations of pip-compile: we could certainly write "ipython 7.9 on py35, latest ipython otherwise" into our Leaving the ipython pin at 7.9 temporarily wouldn't be the end of the world. The ipython hook we're testing has never broken in the whole time trio has existed, so it's not super likely that they're going to break it now. That's not workable in the long term though. At some point we'll drop 3.5 support, which will solve this problem. Doing it because of an optional dependency like ipython feels a bit weird, but thinking about this is taking up time that could be used for other things, so maybe. I'm not sure how we should handle dropping support for an interpreter version like that, but I guess we have to figure it out eventually. (Mostly I'm worried about how we warn our users, and ideally get feedback. Maybe we should start with a release that issues a deprecation warning when imported on 3.5?) We could also work around this particular issue with some hack. Not sure exactly what that would look like, but like, in |
The scientific Python ecosystem is going to drop older Python versions much more agressively, see https://numpy.org/neps/nep-0029-deprecation_policy.html. If I understand correctly, Python supports its old versions for 60 months (5 years), while numpy and friends only support it for 42 months (3.5 years). In any case, the next version to be dropped is Python 3.6:
So we'll have the same problem soon for 3.6, which I don't think we want do drop now given our reluctance to drop Python 3.5. So we'll have to fix our tooling here whether we drop Python 3.5 or not, right? |
Superseded by #1325. |
Bumps ipython from 7.9.0 to 7.10.0.
Commits
cd9f522
release 7.10.0d5e408b
update github stats8a205b8
Merge pull request #11966 from Carreau/wnc671abf
update changes in API6ba2738
update whats new0e09a62
Merge pull request #11726 from jonathanslenders/prompt_toolkit-3.0c2a5384
Support prompt_toolkit 3.0 as well.734fe81
Merge pull request #11964 from techtonik/patch-37382f0c
Fill in some missing wordsff71f9f
Expand docs on how cells are executedDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.If all status checks pass Dependabot will automatically merge this pull request.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: