Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ipython from 7.9.0 to 7.10.0 #1320

Closed
wants to merge 1 commit into from

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Nov 28, 2019

Bumps ipython from 7.9.0 to 7.10.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Nov 28, 2019
@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/pip/ipython-7.10.0 branch from f2f7482 to c29ef2d Compare November 29, 2019 06:21
@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #1320 into master will decrease coverage by 0.3%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
- Coverage   99.69%   99.38%   -0.31%     
==========================================
  Files         106      106              
  Lines       13008    13008              
  Branches      996      996              
==========================================
- Hits        12968    12928      -40     
- Misses         23       54      +31     
- Partials       17       26       +9
Impacted Files Coverage Δ
trio/_util.py 80.95% <0%> (-19.05%) ⬇️
trio/_deprecated_ssl_reexports.py 90% <0%> (-10%) ⬇️
trio/_core/_windows_cffi.py 97.26% <0%> (-2.74%) ⬇️
trio/_core/_multierror.py 98.78% <0%> (-1.22%) ⬇️
trio/_core/tests/test_ki.py 99.02% <0%> (-0.98%) ⬇️
trio/tests/test_util.py 99.14% <0%> (-0.86%) ⬇️
trio/_path.py 99.2% <0%> (-0.8%) ⬇️
trio/_core/tests/test_multierror.py 99.24% <0%> (-0.76%) ⬇️
trio/tests/test_ssl.py 99.71% <0%> (-0.29%) ⬇️
trio/_core/tests/test_run.py 99.74% <0%> (-0.26%) ⬇️
... and 4 more

@dependabot-preview dependabot-preview bot force-pushed the dependabot/pip/ipython-7.10.0 branch from c29ef2d to 5289a64 Compare November 29, 2019 07:19
@pquentin
Copy link
Member

IPython 7.10+ supports Python 3.6 and above, following NEP 29.

https://github.com/ipython/ipython/blob/7.10.0/setup.py#L45-L48

@njsmith
Copy link
Member

njsmith commented Nov 29, 2019

Ick, so I guess this is another situation where we're hitting the limitations of pip-compile: we could certainly write "ipython 7.9 on py35, latest ipython otherwise" into our requirements.in, but dependabot isn't able to propagate that into requirements.txt :-(

Leaving the ipython pin at 7.9 temporarily wouldn't be the end of the world. The ipython hook we're testing has never broken in the whole time trio has existed, so it's not super likely that they're going to break it now. That's not workable in the long term though.

At some point we'll drop 3.5 support, which will solve this problem. Doing it because of an optional dependency like ipython feels a bit weird, but thinking about this is taking up time that could be used for other things, so maybe. I'm not sure how we should handle dropping support for an interpreter version like that, but I guess we have to figure it out eventually. (Mostly I'm worried about how we warn our users, and ideally get feedback. Maybe we should start with a release that issues a deprecation warning when imported on 3.5?)

We could also work around this particular issue with some hack. Not sure exactly what that would look like, but like, in ci.sh we could manually override the ipython requirement somehow.

@pquentin
Copy link
Member

The scientific Python ecosystem is going to drop older Python versions much more agressively, see https://numpy.org/neps/nep-0029-deprecation_policy.html.

If I understand correctly, Python supports its old versions for 60 months (5 years), while numpy and friends only support it for 42 months (3.5 years). In any case, the next version to be dropped is Python 3.6:

a project with a major or minor version released in December 2019 should support Python 3.6 and newer

So we'll have the same problem soon for 3.6, which I don't think we want do drop now given our reluctance to drop Python 3.5. So we'll have to fix our tooling here whether we drop Python 3.5 or not, right?

@dependabot-preview
Copy link
Contributor Author

Superseded by #1325.

@dependabot-preview dependabot-preview bot deleted the dependabot/pip/ipython-7.10.0 branch December 2, 2019 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants