Add new trio.to_thread module for running worker threads #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with trio.from_thread, and to give us a place for future extensions, like utilities for pushing context managers into threads. See python-triogh-810.
Codecov Report
@@ Coverage Diff @@
## master #1156 +/- ##
==========================================
+ Coverage 99.55% 99.55% +<.01%
==========================================
Files 105 106 +1
Lines 12716 12717 +1
Branches 970 970
==========================================
+ Hits 12659 12660 +1
Misses 36 36
Partials 21 21
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1156 +/- ##
==========================================
+ Coverage 99.55% 99.55% +<.01%
==========================================
Files 105 106 +1
Lines 12716 12717 +1
Branches 970 970
==========================================
+ Hits 12659 12660 +1
Misses 36 36
Partials 21 21
|
epellis
approved these changes
Jul 31, 2019
|
@epellis I know, for a library that tries to avoid threads we sure do use or mention threads a lot :-) Want to go ahead and hit the green merge button? |
|
woot 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with trio.from_thread, and to give us a place for
future extensions, like utilities for pushing context managers into
threads.
See gh-810.