Updates for Trio 0.15 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 21c5916. We should still be explicitly passing the loop to avoid any mistakes.
Using `with trio_asyncio.open_loop` (instead of async with) fails with `AttributeError: __enter__` on Python 3.7+.
The loop argument is deprecated, but according to reviewers we still want to use it. Configuring this in pytest.ini makes AppVeyor and Travis consistent again.
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 79.90% 80.29% +0.39%
==========================================
Files 11 11
Lines 1229 1228 -1
Branches 171 171
==========================================
+ Hits 982 986 +4
+ Misses 173 171 -2
+ Partials 74 71 -3
|
|
I decided to ignore Windows + 3.8 for now as I don't know how to skip a specific asyncio test. Please take a look. |
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a few commits on top of #82:
I still have one error in a Windows + Python 3.8 test: https://ci.appveyor.com/project/pquentin/trio-asyncio/builds/33592085/job/gmo3loxfg3402xf6. Maybe we should leave Windows + Python 3.8 full testsuite support for another pull request?
Closes #82