Fix compatibility with e.g. Sybil #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
approved these changes
Nov 4, 2022
|
I've confirmed locally, yep. I don't think it actually makes sense to fix in Sybil as there's no Python object to assign, and constructing a proxy would mostly break other things. |
|
Sorry we don't have automation to release on every commit, is it OK if I delay this one until we have more changes or waited for a few weeks? You can also release yourself if needed |
|
Yep, waiting a few weeks isn't a problem here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #132; it's a trival enough patch for a sufficiently esoteric case that I didn't add tests.