-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api 4.8 #1917
Api 4.8 #1917
Conversation
@Bibo-Joshi Last time I faced this error in the support groups I suggested checking the dimensions of it. Maybe try uploading said photo as document, if that works, that might be it? |
@Poolitzer Problem seems to be sending a photo via with open('tests/data/thumb.jpg', 'rb') as f: bot.send_photo(chat_id, f) Problem persists, if I swat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great PR, slight improvement
One thing: What about adding the emojis from Dice as constants? We normally do that. Right now we only have a list. |
Added that. Still kept the |
@Bibo-Joshi Sure, didnt complain about that ;P |
CI Fail: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good. A small comment on docstring.
However, I did not understand the following action item in the PR description:
Release notification should maybe include a statemant, that Dice a second positional argument.
Co-authored-by: Noam Meltzer <[email protected]>
Pure API changes
Bot.send_poll
:explanation
,explanation_parse_mode
,Poll.{explanation, explanation_entities, open_period, close_date}
Bot.send_dice
:emoji
(for whatever reason, sending a 'darts' is considered a die now …Dice.emoji
Convenience stuff
Poll.parse_explanation_entity/ies
Filters.dice.dice
andFilters.dice.darts
for filtering only the corresponding emojis. Allow theFilters.dice.*([1, 2])
syntax for bothTodo
Dice
a second positional argument.telegram.error.BadRequest: Type of file mismatch
. Need to investigate