Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of CallbackQuery in Examples #1721

Merged
merged 2 commits into from
Mar 28, 2020
Merged

Improve handling of CallbackQuery in Examples #1721

merged 2 commits into from
Mar 28, 2020

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Jan 23, 2020 •
edited
Loading

  • Answer CallbackQueries even if message is edited
  • Use CQs shortcut for edit_message_text

Closes #1712

@Bibo-Joshi Bibo-Joshi added the ⚙️ examples affected functionality: examples label Jan 23, 2020
@Bibo-Joshi Bibo-Joshi added this to the 12.5 milestone Jan 23, 2020
github-actions[bot]
github-actions bot reviewed Jan 23, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

@Bibo-Joshi
Copy link
Member Author

Bibo-Joshi commented Jan 23, 2020 •
edited by Poolitzer
Loading

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

Don't really need to. Nothing unreleased is used.

Edit:
Don't be so harsh to him, he is doing his best ~Poolitzer

Poolitzer
Poolitzer approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid change, nothing to worry about. Good job

examples/inlinekeyboard.py Show resolved Hide resolved
examples/inlinekeyboard2.py Show resolved Hide resolved
examples/nestedconversationbot.py
@@ -66,6 +66,7 @@ def start(update, context):

# If we're starting over we don't need do send a new message
if context.user_data.get(START_OVER):
update.callback_query.answer()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should do query = update.callbackquery in this file as well?

@Bibo-Joshi Telegram GithubBot Revised
Copy link
Member Author

@Poolitzer I understood from @EchteEldin that the Keyboard wouldn't change for him because the CallbackQuery wasn't answered before editing the message. That's why I answer before editing.

@Bibo-Joshi
Copy link
Member Author

CI fails unrelated, since I only changed the examples

@Bibo-Joshi Bibo-Joshi merged commit f94ea9a into master Mar 28, 2020
@Bibo-Joshi Bibo-Joshi deleted the answer_cqs_in_expls branch March 28, 2020 11:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Poolitzer Poolitzer Poolitzer approved these changes

Assignees
No one assigned
Labels
⚙️ examples affected functionality: examples
Projects
None yet
Milestone
12.6
Development

Successfully merging this pull request may close these issues.

Answer CallbackQueryies in Examples
2 participants
@Bibo-Joshi @Poolitzer