Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated Atlassian field name #940

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

fsto
Copy link
Contributor

@fsto fsto commented Oct 24, 2024

Proposed changes

Remove usage name in favor for accountId for Atlassian backend. Fixes Issue 517 - essentially a KeyError when trying to access name.
SCR-20241024-tvtj

Atlassian deprecation notice 1 October 2018:

By 29 April 2019, we will remove personal data from the API that is used to identify users, such as username and userKey, and instead use the Atlassian account ID (accountId). Additionally, will be restricting the visibility of other personal data, such as email, in conjunction with a user's profile privacy settings.

Further down in the same deprecation notice:

Field Change Nullable Notes
name REMOVED N/A Use accountId instead.

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

Other information

Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.

@nijel nijel merged commit f6d0cdd into python-social-auth:master Oct 25, 2024
7 checks passed
@nijel
Copy link
Member

nijel commented Oct 25, 2024

Merged, thanks for your contribution!

@nijel nijel self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

The Atlassian Backend is broken
2 participants