-
-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New backend for the WLCG IAM testing site #820
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #820 +/- ##
==========================================
- Coverage 77.80% 77.11% -0.69%
==========================================
Files 330 337 +7
Lines 10097 10262 +165
Branches 1195 690 -505
==========================================
+ Hits 7856 7914 +58
- Misses 2087 2192 +105
- Partials 154 156 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Hi, how can I fix the checks? |
Adding email scope in default scope
Can you please add tests for the backend? |
Thanks for your comment. |
One of OAuth2 tests can be found here: https://github.com/python-social-auth/social-core/blob/master/social_core/tests/backends/test_digitalocean.py |
for more information, see https://pre-commit.ci
Hi, I have added a test, but not sufficient according to the codecov test. Could you give me some more guidance how to proceed? |
Merged, thanks for your contribution! |
Proposed changes
Adding the WLCG IAM backend testing site.
Types of changes
Please check the type of change your PR introduces:
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.
Other information
I have tested using this backend with a local galaxy server. I can get id_token, access_token and refresh_token and things seem to work as expected.