Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New backend for the WLCG IAM testing site #820

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

maikenp
Copy link
Contributor

@maikenp maikenp commented Aug 18, 2023

Proposed changes

Adding the WLCG IAM backend testing site.

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

I have tested using this backend with a local galaxy server. I can get id_token, access_token and refresh_token and things seem to work as expected.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.69% ⚠️

Comparison is base (cf95380) 77.80% compared to head (c6b1504) 77.11%.
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage   77.80%   77.11%   -0.69%     
==========================================
  Files         330      337       +7     
  Lines       10097    10262     +165     
  Branches     1195      690     -505     
==========================================
+ Hits         7856     7914      +58     
- Misses       2087     2192     +105     
- Partials      154      156       +2     
Flag Coverage Δ
unittests 77.11% <100.00%> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
social_core/backends/wlcg.py 100.00% <100.00%> (ø)
social_core/tests/backends/test_wlcg.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maikenp
Copy link
Contributor Author

maikenp commented Aug 30, 2023

Hi, how can I fix the checks?

Adding email scope in default scope
@nijel
Copy link
Member

nijel commented Sep 12, 2023

Can you please add tests for the backend?

@maikenp
Copy link
Contributor Author

maikenp commented Sep 12, 2023

Can you please add tests for the backend?

Thanks for your comment.
There is little documentation on how you want those tests to be. What tests do you want, and in what way?
Is there an example of a backend test that I could follow?

@nijel
Copy link
Member

nijel commented Sep 12, 2023

@maikenp
Copy link
Contributor Author

maikenp commented Sep 15, 2023

Can you please add tests for the backend?

Hi, I have added a test, but not sufficient according to the codecov test. Could you give me some more guidance how to proceed?

@nijel nijel merged commit ca841a0 into python-social-auth:master Sep 19, 2023
6 of 7 checks passed
@nijel
Copy link
Member

nijel commented Sep 19, 2023

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants