Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #240: use default on None Float field #327

Merged
merged 3 commits into from
Jun 1, 2021
Merged

Issue #240: use default on None Float field #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cfd559
Fix for issue #240 + test.
bdscharf May 27, 2021
1abc02f
Merge branch 'master' into issue-240
bdscharf May 27, 2021
aa3492d
Capitalization fix.
bdscharf May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions flask_restx/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,8 @@ class Float(NumberMixin, Raw):

def format(self, value):
try:
if value is None:
return self.default
return float(value)
except (ValueError, TypeError) as ve:
raise MarshallingError(ve)
Expand Down
6 changes: 6 additions & 0 deletions tests/test_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,12 @@ def test_with_default(self):
assert not field.required
assert field.__schema__ == {"type": "number", "default": 0.5}

def test_none_uses_default(self):
field = fields.Float(default=0.5)
assert not field.required
assert field.__schema__ == {"type": "number", "default": 0.5}
assert field.format(None) == 0.5

@pytest.mark.parametrize(
"value,expected", [("-3.13", -3.13), (str(-3.13), -3.13), (3, 3.0),]
)
Expand Down