Skip to content

Commit

Permalink
Fix testing for Flask 3.1.0 changes. (#629)
Browse files Browse the repository at this point in the history
* Fix testing for Flask 3.1.0 changes.

* Deprecate python 3.8.

---------

Co-authored-by: Peter Doggart <[email protected]>
  • Loading branch information
peter-doggart and Peter Doggart authored Nov 28, 2024
1 parent dbd6f0d commit ffb079c
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Set up Python 3.8
- name: Set up Python 3.9
uses: actions/setup-python@v1
with:
python-version: 3.8
python-version: 3.9
- name: Checkout code
uses: actions/checkout@v2
- name: Install dependencies
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "pypy3.8", "3.12"]
python-version: ["3.9", "3.10", "3.11", "pypy3.9", "3.12"]
flask: ["<3.0.0", ">=3.0.0"]
steps:
- name: Set up Python ${{ matrix.python-version }}
Expand All @@ -41,10 +41,10 @@ jobs:
runs-on: ubuntu-latest
if: github.event_name == 'pull_request'
steps:
- name: Set up Python 3.8
- name: Set up Python 3.9
uses: actions/setup-python@v4
with:
python-version: "3.8"
python-version: "3.9"
- name: Checkout ${{ github.base_ref }}
uses: actions/checkout@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ and expose its documentation properly using `Swagger`_.
Compatibility
=============

Flask-RESTX requires Python 3.8+.
Flask-RESTX requires Python 3.9+.

On Flask Compatibility
======================
Expand Down
2 changes: 1 addition & 1 deletion doc/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ development and to support our users.
Compatibility
=============

Flask-RESTX requires Python 3.8+.
Flask-RESTX requires Python 3.9+.


Installation
Expand Down
2 changes: 1 addition & 1 deletion doc/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ The development version can be downloaded from
pip install -e .[dev,test]
Flask-RESTX requires Python version 3.8+.
Flask-RESTX requires Python version 3.9+.
It's also working with PyPy and PyPy3.
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ def pip(filename):
"Topic :: System :: Software Distribution",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand All @@ -111,5 +110,5 @@ def pip(filename):
"Topic :: Software Development :: Libraries :: Python Modules",
"License :: OSI Approved :: BSD License",
],
python_requires=">=3.8",
python_requires=">=3.9",
)
2 changes: 1 addition & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def get_specs(self, prefix="", status=200, **kwargs):

@pytest.fixture
def app():
app = Flask(__name__)
app = Flask(__name__, subdomain_matching=True)
app.test_client_class = TestClient
yield app

Expand Down
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@

[tox]
envlist =
py{38, 39, 310, 311}-flask2,
py{39, 310, 311}-flask2,
py{311, 312}-flask3
pypy3.8
pypy3.9
doc

[testenv]
Expand Down

0 comments on commit ffb079c

Please sign in to comment.