Support parsing annotations with more than one dot in the name #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was tripping up on this line from QtGui.QPainter when running on an
updated PyQt (6.3.1):
def drawConvexPolygon(self, points: PyQt6.sip.array[QtCore.QPointF]) -> None: ...
Here PyQt6.sip.array is Attribute(Attribute(Name)) and we can supported
arbitrarily dotted names by recursing.
Also there is an attribute in the slice too which apparently wasn't
supported before.
I'm not sure what test case this should/could have. Importing QtGui and
calling the function with the right signature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was tripping up on this line from QtGui.QPainter when running on an updated PyQt (6.3.1):
Here PyQt6.sip.array is Attribute(Attribute(Name)) and we can supported arbitrarily dotted names by recursing.
Also there is an attribute in the slice too which apparently wasn't supported before.
I'm not sure what test case this should/could have. Importing QtGui and calling the function with the right signature?