Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include stubs for PyQt6-WebEngine too #6

Open
toofar opened this issue May 15, 2022 · 0 comments
Open

Include stubs for PyQt6-WebEngine too #6

toofar opened this issue May 15, 2022 · 0 comments

Comments

@toofar
Copy link

toofar commented May 15, 2022

It looks like the stubs for PyQt6-WebEngine are not currently included, they are in the PyQt5-stub package.

toofar added a commit to qutebrowser/qutebrowser that referenced this issue Jun 26, 2022
My for has Webengine stubs included too. All autogenerated with no
specific codemods or anything yet. Ref python-qt-tools/PyQt6-stubs#6

Switching to just PyQt6 instead of both 5 and 6 installed at the moment
because ... it cases about half as many mypy errors. There are a lot of
places like:

    if gettatt(...):
        # pyqt6
        ...
    else:
        # pyqt5
        ...

that mypy has no idea about. I'm not sure the best way to guide it at
this point. Even once I figure that out I'm not sure that doing one run
with both 5+6 is the way to go, we might want to split mypy into two
runs.
toofar added a commit to qutebrowser/qutebrowser that referenced this issue Jun 26, 2022
My for has Webengine stubs included too. All autogenerated with no
specific codemods or anything yet. Ref python-qt-tools/PyQt6-stubs#6

Switching to just PyQt6 instead of both 5 and 6 installed at the moment
because ... it cases about half as many mypy errors. There are a lot of
places like:

    if gettatt(...):
        # pyqt6
        ...
    else:
        # pyqt5
        ...

that mypy has no idea about. I'm not sure the best way to guide it at
this point. Even once I figure that out I'm not sure that doing one run
with both 5+6 is the way to go, we might want to split mypy into two
runs.
toofar added a commit to qutebrowser/qutebrowser that referenced this issue Jul 3, 2022
My for has Webengine stubs included too. All autogenerated with no
specific codemods or anything yet. Ref python-qt-tools/PyQt6-stubs#6

Switching to just PyQt6 instead of both 5 and 6 installed at the moment
because ... it cases about half as many mypy errors. There are a lot of
places like:

    if gettatt(...):
        # pyqt6
        ...
    else:
        # pyqt5
        ...

that mypy has no idea about. I'm not sure the best way to guide it at
this point. Even once I figure that out I'm not sure that doing one run
with both 5+6 is the way to go, we might want to split mypy into two
runs.
toofar added a commit to qutebrowser/qutebrowser that referenced this issue Jul 3, 2022
My for has Webengine stubs included too. All autogenerated with no
specific codemods or anything yet. Ref python-qt-tools/PyQt6-stubs#6

Switching to just PyQt6 instead of both 5 and 6 installed at the moment
because ... it cases about half as many mypy errors. There are a lot of
places like:

    if gettatt(...):
        # pyqt6
        ...
    else:
        # pyqt5
        ...

that mypy has no idea about. I'm not sure the best way to guide it at
this point. Even once I figure that out I'm not sure that doing one run
with both 5+6 is the way to go, we might want to split mypy into two
runs.
toofar added a commit to qutebrowser/qutebrowser that referenced this issue Jul 30, 2022
My fork has Webengine stubs included too. All autogenerated with no
specific codemods or anything yet. Ref python-qt-tools/PyQt6-stubs#6

Switching to just PyQt6 instead of both 5 and 6 installed at the moment
because ... it causes about half as many mypy errors. There are a lot of
places like:

    if gettatt(...):
        # pyqt6
        ...
    else:
        # pyqt5
        ...

that mypy has no idea about. I'm not sure the best way to guide it at
this point. Even once I figure that out I'm not sure that doing one run
with both 5+6 is the way to go, we might want to split mypy into two
runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant