Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR for the discussion about PyQt6 here: #69
This PR contains some adjustments to the lib, but most importantly the adapted pyi-File for QtCore. It's basically a merge between the upstream pyi-File and the current stubs (or more precisely, the fixes of the current stubs).
Here are some things that must be discussed:
bytes
andQByteArray
. Actually, the stubs define a Buffer (PyQt6.sip.Buffer
) like this:Buffer = Union[bytes, bytearray, memoryview, array, voidptr]
, but don't use it a lot. What we use istyping.Union[QByteArray, bytes, bytearray]
. The stubs use either aQByteArray
, ortyping.Union[QByteArray, bytes, bytearray, memoryview]
. We should be consistent...QObjectT
?I'm not sure if this is the right way to go forward with PyQt6 (@The-Compiler already said correctly that we could or should use some automation) - any feedback is highly appreciated. And if someone has a better way or is more experienced - go on and take over. I will just need the stubs in the end ;)