Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Clear the existing table header #234

Merged
merged 2 commits into from
Sep 26, 2022
Merged

fix: Clear the existing table header #234

merged 2 commits into from
Sep 26, 2022

Conversation

frostming
Copy link
Contributor

Fix #230

@frostming frostming force-pushed the fix/update-table-header branch from 28993c0 to 3b0c8e4 Compare September 14, 2022 02:07
@frostming frostming mentioned this pull request Sep 14, 2022
Merged
2 tasks
@Secrus
Copy link
Member

Secrus commented Sep 15, 2022

If you are removing py.typed file, you might want to remove it from the tool.poetry.include section in pyproject.toml.

Also, I don't think removing the marker file is a good choice. It will break people's mypy checks. I would rather encourage working on proper typing for tomlkit rather than going back to not-typed way.

radoering pushed a commit to python-poetry/poetry that referenced this pull request Sep 16, 2022
@frostming
fix: wrong nested table level when overwriting pyproject (#6512)
20352b6 
Previously, we rely on the `display_name` stored with `tomlkit.Table`,
which is an internal implementation detail, and it breaks
python-poetry/tomlkit#234. This PR corrects the
nested table level, because `preserved` map comes from the poetry config
table.
poetry-bot bot pushed a commit to python-poetry/poetry that referenced this pull request Sep 16, 2022
@frostming @github-actions
fix: wrong nested table level when overwriting pyproject (#6512)
e20ee9c 
Previously, we rely on the `display_name` stored with `tomlkit.Table`,
which is an internal implementation detail, and it breaks
python-poetry/tomlkit#234. This PR corrects the
nested table level, because `preserved` map comes from the poetry config
table.

(cherry picked from commit 20352b6)
radoering pushed a commit to python-poetry/poetry that referenced this pull request Sep 16, 2022
@frostming @radoering
fix: wrong nested table level when overwriting pyproject (#6512)
fc4bc0c 
Previously, we rely on the `display_name` stored with `tomlkit.Table`,
which is an internal implementation detail, and it breaks
python-poetry/tomlkit#234. This PR corrects the
nested table level, because `preserved` map comes from the poetry config
table.

(cherry picked from commit 20352b6)
@frostming frostming force-pushed the fix/update-table-header branch from 2f65374 to d4885a4 Compare September 26, 2022 06:53
@frostming frostming merged commit 5bc89ed into master Sep 26, 2022
@frostming frostming deleted the fix/update-table-header branch September 26, 2022 07:49
capuanob pushed a commit to capuanob/tomlkit that referenced this pull request Mar 1, 2023
@frostming
fix: Clear the existing table header (python-poetry#234)
de9293e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table.update(TOMLDocument) is missing a nesting level
2 participants
@frostming @Secrus